fix: accept v3 fields in filters when using v3 jobs #2321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minottic
force-pushed
the
v3_filter_pipe
branch
from
08698e7 to
a988d93
Compare
minottic
force-pushed
the
fix_username
branch
2 times, most recently
from
6fc45e1 to
2cd152a
Compare
minottic
force-pushed
the
v3_filter_pipe
branch
from
a988d93 to
6c6196a
Compare
omkar-ethz
approved these changes
Nov 5, 2025
Member
omkar-ethz
left a comment
omkar-ethz
left a comment
There was a problem hiding this comment.
LGTM! minor comment/question
minottic
force-pushed
the
v3_filter_pipe
branch
2 times, most recently
from
c130723 to
ec516aa
Compare
minottic
force-pushed
the
fix_username
branch
2 times, most recently
from
1e3a4e6 to
1c814d8
Compare
minottic
force-pushed
the
v3_filter_pipe
branch
from
ec516aa to
c8c9963
Compare
Fix return types and remove duplicated pipe Add comments
minottic
force-pushed
the
v3_filter_pipe
branch
from
c8c9963 to
2d655e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This bug can be tried in the JOB view in the frontend, where the sorting has no effect. The cause is that the FE sends the fields of V3 to sort, but these have been renamed in the DB so the sorting has no effect. This PR introduces some pipelines that have the effect of mapping the v3 fields input by the client to the DB ones, at all levels, in fields, whereConditions and limits. IMO this logic should take place in all v3 endpoints. If so, it can be implemented in later PRs
It's opened agains #2320 as it reuses the jobv3v4 mapping. I will open against master once merged
Tests included
Documentation
official documentation info