Skip to content

fix: exclude history if fields #2407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minottic merged 2 commits into from
Dec 9, 2025
Merged

fix: exclude history if fields #2407

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6af37fb
fix: exclude history if fields
minottic Dec 9, 2025
648a33d
only include history if fields filter is falsy, to avoid recomputation
omkar-ethz Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/datasets/datasets.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1289,6 +1289,11 @@ export class DatasetsController {
});
if (dataset.length == 0)
throw new ForbiddenException("Unauthorized access");
if (
Array.isArray(filterObj?.fields) &&
!filterObj.fields.includes("history")
)
return dataset[0];
return {
...dataset[0],
history: await this.convertToObsoleteHistory(dataset[0].pid),
Expand Down
13 changes: 13 additions & 0 deletions test/jest-e2e-tests/datasetHistory.e2e-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,4 +127,17 @@ describe("Test v3 history in datasetLifecycle", () => {
expect(typeof lifecycle.previousValue._id).toBe("string");
});
});

it("Should check v3 built history by ID with field not including history", async () => {
const filter = { fields: ["datasetName"] };
await request(app.getHttpServer())
.get(`/api/v3/datasets/${encodeURIComponent(dsId)}`)
.query({ filter: JSON.stringify(filter) })
.auth(token, { type: "bearer" })
.expect(TestData.SuccessfulGetStatusCode)
.then((res) => {
expect(res.body.datasetName).toBeDefined();
expect(res.body.history).toBeUndefined();
});
});
});