Try to enable SI on 1.11 #1169
Open
Try to enable SI on 1.11 #1169
+24
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TorkelE
reviewed
Jan 9, 2025
|
@TorkelE seems SI extension is still hanging on 1.11.2 so I'm going to close this. Seems we can't yet add it back on any Julia version. |
|
that's annoying, but not much to do about |
TorkelE
reviewed
Mar 9, 2025
| @@ -49,7 +49,7 @@ let | |||
| ps = rnd_ps(custom_function_network_1, rng; factor) | |||
| t = rand(rng) | |||
| @test f_eval(custom_function_network_1, u0, ps, t) ≈ f_eval(custom_function_network_2, u0, ps, t) | |||
| @test jac_eval(custom_function_network_1, u0, ps, t) ≈ jac_eval(custom_function_network_2, u0, ps, t) | |||
| @test_broken jac_eval(custom_function_network_1, u0, ps, t) ≈ jac_eval(custom_function_network_2, u0, ps, t) # Weird error dur to some SciML update. Reported in https://github.com/SciML/ModelingToolkit.jl/issues/3447. | |||
There was a problem hiding this comment.
This change is actually done in #1192 (but this PR is based off that one).
TorkelE
reviewed
Mar 9, 2025
| @@ -113,7 +113,7 @@ function SI.assess_identifiability(rs::ReactionSystem, args...; | |||
| funcs_to_check = make_ftc(funcs_to_check, conseqs, vars) | |||
|
|
|||
| # Computes identifiability and converts it to a easy to read form. | |||
| out = SI.assess_identifiability(osys, args...; measured_quantities, | |||
| out = SI.assess_identifiability(osys::ODESystem, args...; measured_quantities, | |||
There was a problem hiding this comment.
This is the bit that solves it. What actually goes on is a royal mystery, but there is some discussion here: https://discourse.julialang.org/t/how-to-debug-an-error-in-type-inference/126122/8 and here: SciML/StructuralIdentifiability.jl#360
|
Builds on the change in #1192, however, otherwise this is now ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.