Update documentation of save_start and save_end #1251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify the complicated current behaviour of `save_start` and `save_end` in the documentation, addressing the issue mentioned in OrdinaryDiffEq.jl#1842. This is a rebased version of PR SciML#977 by @ArneBouillon, which was significantly behind master. Co-Authored-By: ArneBouillon <[email protected]> Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
save_startandsave_endin the documentationsave_startandsave_end#977 by @ArneBouillon, which was ~200 commits behind masterFixes SciML/OrdinaryDiffEq.jl#1842
Test plan
Pkg.test()locally - all tests pass🤖 Generated with Claude Code