Import DEFAULT_UPDATE_FUNC from SciMLOperators instead of SciMLBase #1253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change imports DEFAULT_UPDATE_FUNC directly from SciMLOperators where it is defined, rather than from SciMLBase which was re-exporting it. This fixes compatibility with SciML/SciMLBase.jl#1203 which improves explicit imports hygiene and removes the transitive re-export of DEFAULT_UPDATE_FUNC. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DEFAULT_UPDATE_FUNCdirectly fromSciMLOperatorswhere it is definedSciMLBasewhich was re-exporting itMotivation
This change is needed to maintain compatibility with SciML/SciMLBase.jl#1203 which improves explicit imports hygiene. That PR removes the transitive re-export of
DEFAULT_UPDATE_FUNCfromSciMLBase, so downstream packages need to import it directly fromSciMLOperators.Test plan
DEFAULT_UPDATE_FUNCis exported bySciMLOperators🤖 Generated with Claude Code