Skip to content

more ITP simplification #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 27, 2025

Conversation

oscardssmith
Copy link
Member

followup to #547. There is one minor change in that diff now is always positive (following the algorithm description in the paper and https://en.wikipedia.org/wiki/ITP_method). Otherwise, this should be nfc.

@ChrisRackauckas
Copy link
Member

Conflicts?

@oscardssmith
Copy link
Member Author

conflicts fixed. Possibly worth noting that this PR currently adds stats since stats are really useful for seeing if the alg works, but do add an allocation of the stats object to previously non-allocating code. Thoughts?

@oscardssmith
Copy link
Member Author

also, is the intended behavior different depending on whether tspan is forwards or backwards?

@ChrisRackauckas
Copy link
Member

We've normally tried to make all of the bracketing methods all non-allocating since they don't necessarily need any. I'd comment out the stats stuff until we get a better solution there then.

@oscardssmith
Copy link
Member Author

stats removed. I think this is now ready.

@oscardssmith
Copy link
Member Author

It's very hard for me to see how the test failures could be my fault, but otoh I know that theoretically they all should be working now.

@ChrisRackauckas
Copy link
Member

Downgrade and Windows are not yours. Those are just CI infra issues. @avik-pal you had something for the Windows stuff?

@ChrisRackauckas ChrisRackauckas merged commit 42b4e8b into SciML:master Mar 27, 2025
57 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants