-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Updates for OptimizationBase v2 #789
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vaibhavdixit02
commented
Aug 14, 2024
end | ||
return | ||
end | ||
|
||
function MOI.hessian_lagrangian_structure(evaluator::MOIOptimizationNLPEvaluator) | ||
lagh = evaluator.f.lag_h !== nothing | ||
if evaluator.f.lag_hess_prototype !== nothing | ||
rows, cols, _ = findnz(evaluator.f.lag_hess_prototype) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #439 in combination with OptimizationBase v2
Vaibhavdixit02
changed the title
[WIP] Update tests for OptimizationBase v2
[WIP] Updates for OptimizationBase v2
Aug 23, 2024
call cons_vjp if available
Vaibhavdixit02
added a commit
to SciML/OptimizationBase.jl
that referenced
this pull request
Sep 10, 2024
Changes for getting SciML/Optimization.jl#789 passing
Vaibhavdixit02
force-pushed
the
optbasev2
branch
from
September 11, 2024 17:22
7cb4541
to
951d661
Compare
Vaibhavdixit02
force-pushed
the
optbasev2
branch
2 times, most recently
from
September 13, 2024 14:18
ba6ff6b
to
d4a6d5b
Compare
Vaibhavdixit02
force-pushed
the
optbasev2
branch
6 times, most recently
from
September 15, 2024 12:28
42896b6
to
2a65678
Compare
Vaibhavdixit02
force-pushed
the
optbasev2
branch
from
September 15, 2024 12:50
2a65678
to
6e4616f
Compare
Vaibhavdixit02
force-pushed
the
optbasev2
branch
from
September 17, 2024 20:59
5a177c6
to
f1c5a4e
Compare
Vaibhavdixit02
force-pushed
the
optbasev2
branch
from
September 17, 2024 21:01
f1c5a4e
to
ceb503a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.