Allow bigfloats through dualcaches #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could in theory embed a LBC into the DualCache so that it reuses this vector, but I'm not sure it's worth it. Basically, if you have a T that's not bitstype then it's not going to reuse memory and it's going to have to re-allocate every number, so you have lots of memory operations already as requirements for making the T being acted on. In this case, you're really just looking for a functional fallback as there is no such thing as preallocation, so simply making the array you wish to see is a good option.
ErikQQY
reviewed
Aug 16, 2024
Co-authored-by: Qingyu Qu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could in theory embed a LBC into the DualCache so that it reuses this vector, but I'm not sure it's worth it. Basically, if you have a T that's not bitstype then it's not going to reuse memory and it's going to have to re-allocate every number, so you have lots of memory operations already as requirements for making the T being acted on. In this case, you're really just looking for a functional fallback as there is no such thing as preallocation, so simply making the array you wish to see is a good option.