Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the symbolic libraries and fix deprecations #327

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

ChrisRackauckas
Copy link
Member

No description provided.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (0331ee9) to head (06f2084).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
+ Coverage   87.32%   90.10%   +2.77%     
==========================================
  Files          28       28              
  Lines        3314     3314              
==========================================
+ Hits         2894     2986      +92     
+ Misses        420      328      -92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit ae82f0b into master Jun 7, 2024
10 of 11 checks passed
@ChrisRackauckas ChrisRackauckas deleted the symbolic branch June 7, 2024 15:53
@pogudingleb pogudingleb restored the symbolic branch June 7, 2024 16:14
@pogudingleb
Copy link
Collaborator

pogudingleb commented Jun 7, 2024

This PR was not passing CI, so I reopened it.
@ChrisRackauckas I would greatly appreciate if PRs which change the code (not only compats) are merged after I look at them.

Thanks for fixing the depreciation!

pogudingleb added a commit that referenced this pull request Jun 7, 2024
@ChrisRackauckas
Copy link
Member Author

This PR passed all tests? And it was just a depwarn fix?

@pogudingleb
Copy link
Collaborator

This PR passed all tests? And it was just a depwarn fix?

Yes, you can say so: it was failing "Downgrade" test because of the devs inconsistency

@ChrisRackauckas
Copy link
Member Author

Downgrade CI currently has some false negatives because it needs a different resolver, which will hopefully be something added in the next few months.

@pogudingleb
Copy link
Collaborator

Glad to hear about these developments in Downgrade. In this case, it actually spotted a mismatch, I have fixed it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants