-
Notifications
You must be signed in to change notification settings - Fork 414
add support for linux-arm64 #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for this. I've given it a quick review and it all looks good to me. I'll try to make time for a more thorough check this weekend. Have you been able to test it on any arm64 hardware? I don't have anything I could test on. |
Oh CI failures are expected for now, since the binaries are missing (I'll add them at the next llama.cpp version update). |
I haven't tested it yet, my arm64 device was borrowed by my bro. |
Can you keep the new work on the reranker in a new PR please, that keeps this one easier to manage when I'm using it for the next binary version update. Just revert this one back to 5996b40 and open a PR for the reranker stuff when it's ready. Thanks :) |
oops, i'll try to revert this one back to #5996b40 |
As a general tip for PRs: it's generally always better to work in a branch in your fork and PR that, instead of working in master and PRing that. That way it's easier to keep your PRs small and easy to manage :) |
Yes, your suggestion is very pertinent. I myself have found the inconvenience caused by the main branch submitting PR. |
Upgraded Linux runners to Ubuntu 24.04
Upgraded Linux AVX512 to Ubuntu 24
#1137 I have completed the compile.yaml action, but I am unable to test other relevant code for the time being.