Skip to content

add support for linux-arm64 #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

add support for linux-arm64 #1138

wants to merge 11 commits into from

Conversation

nipeone
Copy link

@nipeone nipeone commented Mar 27, 2025

#1137 I have completed the compile.yaml action, but I am unable to test other relevant code for the time being.

@martindevans
Copy link
Member

Thanks for this. I've given it a quick review and it all looks good to me. I'll try to make time for a more thorough check this weekend.

Have you been able to test it on any arm64 hardware? I don't have anything I could test on.

@martindevans
Copy link
Member

Oh CI failures are expected for now, since the binaries are missing (I'll add them at the next llama.cpp version update).

@nipeone
Copy link
Author

nipeone commented Mar 29, 2025

Have you been able to test it on any arm64 hardware? I don't have anything I could test on.

I haven't tested it yet, my arm64 device was borrowed by my bro.

@martindevans
Copy link
Member

Can you keep the new work on the reranker in a new PR please, that keeps this one easier to manage when I'm using it for the next binary version update. Just revert this one back to 5996b40 and open a PR for the reranker stuff when it's ready. Thanks :)

@nipeone
Copy link
Author

nipeone commented Apr 3, 2025

oops, i'll try to revert this one back to #5996b40

@martindevans
Copy link
Member

As a general tip for PRs: it's generally always better to work in a branch in your fork and PR that, instead of working in master and PRing that. That way it's easier to keep your PRs small and easy to manage :)

@nipeone
Copy link
Author

nipeone commented Apr 3, 2025

Yes, your suggestion is very pertinent. I myself have found the inconvenience caused by the main branch submitting PR.

Upgraded Linux runners to Ubuntu 24.04
@martindevans martindevans mentioned this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants