No longer subclass DateConverter
in NetCDFTimeConverter
#127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
This is a proof of concept to show that we can no longer subclass
mpl.dates.DateConverter
inNetCDFTimeConverter
without any ill effects. I think it is unlikely that anyone downstream is depending on this relatively low-level detail of nc-time-axis, so it feels reasonably safe to change without a deprecation cycle, but I would be open to opinions of folks who feel otherwise.xref: matplotlib/matplotlib#24951, matplotlib/matplotlib#25662
cc: @ksunden