Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer subclass DateConverter in NetCDFTimeConverter #127

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

spencerkclark
Copy link
Member

🚀 Pull Request

This is a proof of concept to show that we can no longer subclass mpl.dates.DateConverter in NetCDFTimeConverter without any ill effects. I think it is unlikely that anyone downstream is depending on this relatively low-level detail of nc-time-axis, so it feels reasonably safe to change without a deprecation cycle, but I would be open to opinions of folks who feel otherwise.

xref: matplotlib/matplotlib#24951, matplotlib/matplotlib#25662

cc: @ksunden

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4320c72) 93.10% compared to head (5e7fd71) 93.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files           1        1           
  Lines         203      203           
  Branches       47       47           
=======================================
  Hits          189      189           
  Misses          7        7           
  Partials        7        7           
Impacted Files Coverage Δ
nc_time_axis/__init__.py 93.10% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bjlittle
Copy link
Member

@spencerkclark This is great, thanks for raising this.

Perhaps we should wait for the dust to settle on mpl and then see if this flies?

@spencerkclark
Copy link
Member Author

@bjlittle agreed! In the short term I was posting this to signal to @ksunden that the design matplotlib settles on in matplotlib/matplotlib#25662 does not necessarily need to hinge too strongly on this detail of nc-time-axis.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants