fix: unify genesis timestamp across active modules#2112
Merged
Scottcjn merged 1 commit intoScottcjn:mainfrom Apr 6, 2026
Merged
fix: unify genesis timestamp across active modules#2112Scottcjn merged 1 commit intoScottcjn:mainfrom
Scottcjn merged 1 commit intoScottcjn:mainfrom
Conversation
Contributor
Author
|
For bounty payout, please use RTC wallet: RTC1d48d848a5aa5ecf2c5f01aa5fb64837daaf2f35. |
Owner
|
Merged. Payment: 40 RTC. Addresses #2111. Canonicalizes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Unify GENESIS_TIMESTAMP to Canonical Value Across All Modules
What
Replaces stale/hardcoded
GENESIS_TIMESTAMPvalues in 8 active modules with the canonical production value1764706927(Dec 2, 2025 — chain launch). Adds a cross-module consistency test to prevent regression.Why
Six different genesis timestamps existed across the codebase, causing:
1728000000) in arithmetic expressions, checking the wrong 24-hour window for duplicate identity detection (~425 epochs offset)Changes
Constants Updated (7 files)
node/governance.py17000000001764706927node/rustchain_block_producer.py17280000001764706927node/rewards_implementation_rip200.py17280000001764706927node/rip_200_round_robin_1cpu1vote_v2.py17280000001764706927node/rustchain_migration.py17280000001764706927fossils/fossil_record_export.py17280000001764706927rips/rustchain-core/config/chain_params.py17356896001764706927Hardcoded Literals Replaced (1 file)
node/anti_double_mining.py— Added module-levelGENESIS_TIMESTAMPandBLOCK_TIMEconstants; replaced 6 hardcoded arithmetic literals across 4 functions (get_epoch_miner_groups,settle_epoch_with_anti_double_mining,calculate_anti_double_mining_rewards,__main__test block)New Test (1 file)
tests/test_genesis_timestamp_consistency.py— 5 test properties:GENESIS_TIMESTAMPattribute1764706927Testing
Scope
deprecated/old_nodes/intentionally untouched.Risk
Low. This is a constant-only change. The canonical value
1764706927is already used by the primary consensus module (rip_200_round_robin_1cpu1vote.py), the integrated node, and the claims eligibility module. This PR brings the remaining modules into alignment.