fix: prevent tempfile resource leak in POA genesis validator API#4058
fix: prevent tempfile resource leak in POA genesis validator API#4058BossChaos wants to merge 2 commits intoScottcjn:mainfrom
Conversation
When validate_genesis() raises an exception, the temporary file created with delete=False is never cleaned up, leading to disk space exhaustion over time. Wrapped the temp file handling in try/finally to ensure os.remove() is always called, even on validation errors or unexpected exceptions.
haoyousun60-create
left a comment
There was a problem hiding this comment.
Reviewed. Security hardening looks solid. LGTM! 🚀
fengqiankun6-sudo
left a comment
There was a problem hiding this comment.
LGTM! Good security fix. ✅
|
Closing per branch-contamination audit (2026-05-09). This PR is part of a 161-PR cluster from your account where the diff carries files unrelated to the claimed fix. Specifically, 128 of 161 PRs in this batch modify This is a branching-hygiene problem, not a quality problem with the underlying fixes. The pattern means:
To get back to paid status:
I have nothing against the underlying fixes — quality has been good when scoped. But contamination at this scale is unreviewable, and Faucet Tiers policy requires clean diffs for security claims. Specifically clean PRs already approved for payout (per 2026-05-06 audit, still scope-clean as of today):
These will be paid via the admin /wallet/transfer flow. — auto-triage 2026-05-09 (this is mechanical contamination detection, not a personal judgment) |
When validate_genesis() raises an exception, the temporary file created with delete=False is never cleaned up, leading to disk space exhaustion over time. Wrapped in try/finally for guaranteed cleanup.