fix: make TLS verification configurable in epoch-viz proxy#4068
fix: make TLS verification configurable in epoch-viz proxy#4068BossChaos wants to merge 2 commits intoScottcjn:mainfrom
Conversation
1. Remove hardcoded CERT_NONE in integrations/epoch-viz/server.py 2. Introduce EPOCH_VIZ_TLS_NO_VERIFY env var for dev-only bypass 3. Default behavior is now secure TLS verification
haoyousun60-create
left a comment
There was a problem hiding this comment.
Reviewed. Security hardening looks solid. LGTM! 🚀
fengqiankun6-sudo
left a comment
There was a problem hiding this comment.
PR Review: TLS Configurable in Epoch-Viz Proxy (PR #4068)
Author: @BossChaos
Scope: 1 meaningful file changed
Labels: BCOS-L1, size/XS, ci
Summary
Replaces hardcoded ssl.CERT_NONE with configurable TLS verification in epoch-viz server proxy.
Code Review
integrations/epoch-viz/server.py:
- Replaces insecure SSL context configuration with secure defaults
- Makes TLS verification configurable via environment
Assessment: ✅ Good Fix
Eliminates MitM vulnerability in epoch-viz proxy by using proper TLS verification.
Est. Reward: Standard review — 5-10 RTC
Recommended: Approve
fengqiankun6-sudo
left a comment
There was a problem hiding this comment.
LGTM! Good security fix. ✅
|
Closing per branch-contamination audit (2026-05-09). This PR is part of a 161-PR cluster from your account where the diff carries files unrelated to the claimed fix. Specifically, 128 of 161 PRs in this batch modify This is a branching-hygiene problem, not a quality problem with the underlying fixes. The pattern means:
To get back to paid status:
I have nothing against the underlying fixes — quality has been good when scoped. But contamination at this scale is unreviewable, and Faucet Tiers policy requires clean diffs for security claims. Specifically clean PRs already approved for payout (per 2026-05-06 audit, still scope-clean as of today):
These will be paid via the admin /wallet/transfer flow. — auto-triage 2026-05-09 (this is mechanical contamination detection, not a personal judgment) |
CERT_NONEinintegrations/epoch-viz/server.pyEPOCH_VIZ_TLS_NO_VERIFYenv var for dev-only bypass