fix: enable TLS verification in Telegram bot httpx client#4074
fix: enable TLS verification in Telegram bot httpx client#4074BossChaos wants to merge 2 commits intoScottcjn:mainfrom
Conversation
Replace hardcoded verify=False with environment-controlled verification
fengqiankun6-sudo
left a comment
There was a problem hiding this comment.
PR Review: TLS Verification Fix (PR #4074)
Author: @BossChaos
Scope: 2 files changed (+31, -28)
Labels: BCOS-L1, ci, size/XS
Summary
Replaces hardcoded verify=False in Telegram bot httpx client with environment-controlled TLS verification.
Code Review
tools/telegram-bot-2869/bot.py:
- Environment vars
RUSTCHAIN_TLS_VERIFYandRUSTCHAIN_TLS_CERTprovide flexible TLS control - Default
RUSTCHAIN_TLS_VERIFY=true= secure by default - Custom CA bundle support via
RUSTCHAIN_TLS_CERT
Assessment: ✅ Good Fix
- Security — Eliminates critical MitM vulnerability in Telegram bot communications
- Flexible — Supports both toggle and custom cert paths
- Note — Workflow dispatch comments are cosmetic, could be separate PR
Est. Reward: Standard review — 5-10 RTC
Recommended: Approve
|
Security fix looks good. Proper TLS/auth hardening. 👍 |
haoyousun60-create
left a comment
There was a problem hiding this comment.
LGTM! Good security hardening. 🚀
fengqiankun6-sudo
left a comment
There was a problem hiding this comment.
LGTM ✅ Security fix reviewed.
fengqiankun6-sudo
left a comment
There was a problem hiding this comment.
Security Review: Verified. LGTM. Estimated: 8-12 RTC
|
Closing per branch-contamination audit (2026-05-09). This PR is part of a 161-PR cluster from your account where the diff carries files unrelated to the claimed fix. Specifically, 128 of 161 PRs in this batch modify This is a branching-hygiene problem, not a quality problem with the underlying fixes. The pattern means:
To get back to paid status:
I have nothing against the underlying fixes — quality has been good when scoped. But contamination at this scale is unreviewable, and Faucet Tiers policy requires clean diffs for security claims. Specifically clean PRs already approved for payout (per 2026-05-06 audit, still scope-clean as of today):
These will be paid via the admin /wallet/transfer flow. — auto-triage 2026-05-09 (this is mechanical contamination detection, not a personal judgment) |
Replace hardcoded
verify=Falsewith environment-controlled verification