fix: use constant-time Sophia admin checks#4216
Closed
bolasse1234 wants to merge 1 commit intoScottcjn:mainfrom
Closed
fix: use constant-time Sophia admin checks#4216bolasse1234 wants to merge 1 commit intoScottcjn:mainfrom
bolasse1234 wants to merge 1 commit intoScottcjn:mainfrom
Conversation
Contributor
|
Welcome to RustChain! Thanks for your first pull request. Before we review, please make sure:
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150) A maintainer will review your PR soon. Thanks for contributing! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3228 and #3229.
Two Sophia admin paths still compared configured admin keys with plain string equality:
node/sophia_attestation_inspector.pyfor/sophia/inspectand/sophia/batchnode/sophia_governor_review_service.pyfor review-service admin authThis switches those checks to
hmac.compare_digest()and adds regression tests that spy on the comparison path so the tests cover the timing-safe behavior, not just the HTTP status.Severity: Medium timing-side-channel hardening. These are public, already-reported issues; I am claiming clean implementation credit, not first-finder credit.
Payment: please use my GitHub-login miner_id for any payout.
Tests
python -m pytest node\tests\test_sophia_attestation_admin_auth.py node\tests\test_sophia_governor_review_service.py -q=> 15 passedpython -m py_compile node\sophia_attestation_inspector.py node\sophia_governor_review_service.py node\tests\test_sophia_attestation_admin_auth.py node\tests\test_sophia_governor_review_service.pygit diff --check