fix: handle broken article links in bounty verifier#4269
Closed
answndud wants to merge 1 commit intoScottcjn:mainfrom
Closed
fix: handle broken article links in bounty verifier#4269answndud wants to merge 1 commit intoScottcjn:mainfrom
answndud wants to merge 1 commit intoScottcjn:mainfrom
Conversation
Contributor
|
Welcome to RustChain! Thanks for your first pull request. Before we review, please make sure:
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150) A maintainer will review your PR soon. Thanks for contributing! |
Contributor
Author
|
Withdrawing this lower-impact PR to reduce review noise and focus the bounty submissions on higher-impact security/crash/behavior fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #305.
Summary
Bug
BountyVerifier.generate_report(..., article_url=...)currently callsrequests.head(article_url)without a timeout orRequestExceptionhandling. A refused connection, DNS failure, invalid URL, or slow endpoint can raise out of report generation or hang the verifier instead of recording the article as broken.Verification
python3 -m py_compile tools/bounty-bot-pro/verifier.pypython3 - <<'PY'\nimport ast\nfrom pathlib import Path\nast.parse(Path("tools/bounty-bot-pro/verifier.py").read_text())\nprint("parsed")\nPY\n-git diff --check -- tools/bounty-bot-pro/verifier.py\n\nNote: this branch is based onorigin/main, so it still shows the pre-existing invalid-backtick SyntaxWarning that PR fix: remove invalid python escape warnings #4268 fixes separately. This PR is scoped only to the article-link request failure path.