Skip to content

chore(ci): add a workflow for linting GitHub Actions workflow files #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nicomiguelino wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

chore(ci): add a workflow for linting GitHub Actions workflow files #90

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a517e46
chore(ci): add a workflow for linting GitHub Actions workflow files
nicomiguelino Feb 7, 2025
3a464dc
chore(ci): refactor the worklow linter pipeline
nicomiguelino Feb 7, 2025
f229a61
chore(ci): resolve `actionlint` issues
nicomiguelino Feb 7, 2025
585ce0a
chore(ci): enable colored output when running `actionlint`
nicomiguelino Feb 7, 2025
baabbdd
Merge branch 'master' into fix-88
nicomiguelino Feb 9, 2025
5d8ee05
chore(ci): include linting in pre-commit checks
nicomiguelino Feb 10, 2025
3fc150d
docs: add links to "actionlint" and "ESLint"
nicomiguelino Feb 10, 2025
beee8ea
chore(ci): make use of the Dockerized version of `actionlint`
nicomiguelino Feb 10, 2025
d742d78
Merge branch 'master' into fix-88
nicomiguelino Feb 14, 2025
655b696
fix: ci runtime errors
nicomiguelino Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,7 @@ jobs:
export SCREENLY_CE_VERSION="0.0.0"
fi

cat src/manifest-${{ matrix.platform }}.json \
| jq --arg version "$SCREENLY_CE_VERSION" '.version = $version' \
> src/manifest.json
jq --arg version "$SCREENLY_CE_VERSION" '.version = $version' src/manifest-${{ matrix.platform }}.json > src/manifest.json

- name: Build Docker images
run: |
Expand All @@ -45,7 +43,7 @@ jobs:
run: |
docker run \
--rm \
-v $(pwd):/app:delegated \
-v "$(pwd):/app:delegated" \
-v /app/node_modules \
sce_webpack:latest \
/bin/bash -c "npx webpack --config webpack.dev.js && npm run test"
Expand All @@ -55,7 +53,7 @@ jobs:
mkdir artifacts
docker run \
--rm \
-v $(pwd)/artifacts:/app/artifacts:delegated \
-v "$(pwd)/artifacts:/app/artifacts:delegated" \
-v /app/artifacts/node_modules \
sce_webpack:latest \
/bin/bash -c "npm run build && cp -r dist/ artifacts/"
Expand Down
25 changes: 23 additions & 2 deletions .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
name: Run ESLint
name: Run Linters

on:
pull_request:
Expand All @@ -12,7 +12,7 @@ on:
- v*.*

jobs:
build:
eslint:
runs-on: ubuntu-latest
name: Run ESLint
steps:
Expand All @@ -26,3 +26,24 @@ jobs:
- name: Run ESLint
run: |
./bin/host_eslint.sh

actionlint:
runs-on: ubuntu-latest
name: Run Linter for GitHub Actions Workflows
strategy:
matrix:
actionlint-version: ['1.7.7']
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Download actionlint
run: |
ACTIONLINT_FILE="actionlint_${{ matrix.actionlint-version }}_linux_amd64.tar.gz"
ACTIONLINT_URL="https://github.com/rhysd/actionlint/releases/download"
ACTIONLINT_DOWNLOAD_URL="$ACTIONLINT_URL/v${{ matrix.actionlint-version }}/$ACTIONLINT_FILE"
curl -L -o actionlint.tar.gz "$ACTIONLINT_DOWNLOAD_URL"
tar xzf actionlint.tar.gz

- name: Run actionlint
run: ./actionlint -color