Bump tokio from 1.42.0 to 1.43.1 #252
clippy
44 errors
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 44 |
| Warning | 0 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.88.0 (6b00bc388 2025-06-23)
- cargo 1.88.0 (873a06493 2025-05-10)
- clippy 0.1.88 (6b00bc3880 2025-06-23)
Annotations
Check failure on line 61 in src/commands/serde_utils.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/commands/serde_utils.rs:58:38
|
58 | Err(serde::de::Error::custom(format!(
| ______________________________________^
59 | | "Field \"{}\" cannot be empty",
60 | | field_name
61 | | )))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
Check failure on line 41 in src/commands/serde_utils.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/commands/serde_utils.rs:38:39
|
38 | Err(serde::ser::Error::custom(format!(
| _______________________________________^
39 | | "Field \"{}\" cannot be empty",
40 | | field_name
41 | | )))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
Check failure on line 20 in src/commands/serde_utils.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/commands/serde_utils.rs:17:46
|
17 | Err(serde::de::Error::custom(format!(
| ______________________________________________^
18 | | "Field \"{}\" cannot be empty",
19 | | field_name
20 | | )))
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
Check failure on line 26 in src/commands/ignorer.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/commands/ignorer.rs:26:35
|
26 | patterns.push(format!("^{}$", converted));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
26 - patterns.push(format!("^{}$", converted));
26 + patterns.push(format!("^{converted}$"));
|
Check failure on line 140 in src/commands/edge_app/utils.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/commands/edge_app/utils.rs:140:35
|
140 | CommandError::IgnoreError(format!("Failed to initialize ignore module: {}", e))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
140 - CommandError::IgnoreError(format!("Failed to initialize ignore module: {}", e))
140 + CommandError::IgnoreError(format!("Failed to initialize ignore module: {e}"))
|
Check failure on line 101 in src/commands/edge_app/setting.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/commands/edge_app/setting.rs:101:13
|
101 | println!("Setting value is already set to {}", setting_value);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
101 - println!("Setting value is already set to {}", setting_value);
101 + println!("Setting value is already set to {setting_value}");
|
Check failure on line 253 in src/commands/edge_app/server.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/commands/edge_app/server.rs:253:17
|
253 | eprintln!("{}", e);
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
253 - eprintln!("{}", e);
253 + eprintln!("{e}");
|
Check failure on line 221 in src/commands/edge_app/server.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/commands/edge_app/server.rs:221:5
|
221 | format!(" {}: {{\n{}\n }}", name, content)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
221 - format!(" {}: {{\n{}\n }}", name, content)
221 + format!(" {name}: {{\n{content}\n }}")
|
Check failure on line 214 in src/commands/edge_app/server.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/commands/edge_app/server.rs:214:33
|
214 | .map(|item| format!("\"{}\"", item))
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
214 - .map(|item| format!("\"{}\"", item))
214 + .map(|item| format!("\"{item}\""))
|
Check failure on line 209 in src/commands/edge_app/server.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/commands/edge_app/server.rs:209:30
|
209 | Value::Str(s) => format!(" \"{}\": \"{}\"", k, s),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
209 - Value::Str(s) => format!(" \"{}\": \"{}\"", k, s),
209 + Value::Str(s) => format!(" \"{k}\": \"{s}\""),
|
Check failure on line 137 in src/commands/edge_app/server.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/commands/edge_app/server.rs:137:13
|
137 | eprintln!("Failed to parse mock data: {}", e);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
137 - eprintln!("Failed to parse mock data: {}", e);
137 + eprintln!("Failed to parse mock data: {e}");
|
Check failure on line 83 in src/commands/edge_app/server.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/commands/edge_app/server.rs:83:8
|
83 | Ok(format!("http://{}/edge/1", addr))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
83 - Ok(format!("http://{}/edge/1", addr))
83 + Ok(format!("http://{addr}/edge/1"))
|
Check failure on line 160 in src/commands/edge_app/manifest.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/commands/edge_app/manifest.rs:157:49
|
157 | invalid => Err(serde::de::Error::custom(format!(
| _________________________________________________^
158 | | "Invalid syntax: {}. Only 'manifest_v1' is accepted.",
159 | | invalid
160 | | ))),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
Check failure on line 146 in src/commands/edge_app/manifest.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/commands/edge_app/manifest.rs:143:43
|
143 | _ => Err(serde::de::Error::custom(format!(
| ___________________________________________^
144 | | "Invalid auth type: {}",
145 | | s
146 | | ))),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
Check failure on line 73 in src/commands/edge_app/instance_manifest.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/commands/edge_app/instance_manifest.rs:70:49
|
70 | invalid => Err(serde::de::Error::custom(format!(
| _________________________________________________^
71 | | "Invalid syntax: {}. Only 'instance_v1' is accepted.",
72 | | invalid
73 | | ))),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
Check failure on line 468 in src/commands/edge_app/app.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/commands/edge_app/app.rs:468:9
|
468 | println!("{}", prompt);
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
468 - println!("{}", prompt);
468 + println!("{prompt}");
|
Check failure on line 1139 in src/cli.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/cli.rs:1139:29
|
1139 | ... eprintln!("Failed to delete edge app instance. {:?}", e);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
1139 - eprintln!("Failed to delete edge app instance. {:?}", e);
1139 + eprintln!("Failed to delete edge app instance. {e:?}");
|
Check failure on line 886 in src/cli.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/cli.rs:886:25
|
886 | eprintln!("Failed to set edge app setting: {}", e);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
886 - eprintln!("Failed to set edge app setting: {}", e);
886 + eprintln!("Failed to set edge app setting: {e}");
|
Check failure on line 869 in src/cli.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/cli.rs:866:17
|
866 | / println!(
867 | | "Edge app successfully deployed. Revision: {revision}.",
868 | | revision = revision
869 | | );
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
Check failure on line 615 in src/cli.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/cli.rs:615:21
|
615 | println!("{}", pretty_playlist_file);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
615 - println!("{}", pretty_playlist_file);
615 + println!("{pretty_playlist_file}");
|
Check failure on line 133 in src/authentication.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/authentication.rs:133:15
|
133 | let url = format!("{}/v3/groups/11CF9Z3GZR0005XXKH00F8V20R/", api_url);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
133 - let url = format!("{}/v3/groups/11CF9Z3GZR0005XXKH00F8V20R/", api_url);
133 + let url = format!("{api_url}/v3/groups/11CF9Z3GZR0005XXKH00F8V20R/");
|
Check failure on line 35 in src/api/version.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/api/version.rs:32:14
|
32 | ... &format!(
| ________^
33 | | ... "v4.1/edge-apps/versions?select=user_version,description,icon,author,homepage_url,revision,ready_signal&app_id=eq.{}&order=revi...
34 | | ... app_id
35 | | ... ),
| |_______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
Check failure on line 80 in src/api/edge_app/version.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/api/edge_app/version.rs:77:14
|
77 | &format!(
| ______________^
78 | | "v4/edge-apps/versions?app_id=eq.{}&revision=eq.{}",
79 | | app_id, revision
80 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
Check failure on line 59 in src/api/edge_app/version.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/api/edge_app/version.rs:56:14
|
56 | &format!(
| ______________^
57 | | "v4/edge-apps/versions?select=file_tree&app_id=eq.{}&revision=eq.{}",
58 | | app_id, revision
59 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
Check failure on line 19 in src/api/edge_app/version.rs
github-actions / clippy
variables can be used directly in the `format!` string
error: variables can be used directly in the `format!` string
--> src/api/edge_app/version.rs:16:14
|
16 | &format!(
| ______________^
17 | | "v4/edge-apps/versions?select=revision&app_id=eq.{}&revision=eq.{}",
18 | | app_id, revision
19 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args