Skip to content

chore(ci): new CI workflow for linting code#41

Merged
nicomiguelino merged 4 commits intoScreenly:masterfrom
nicomiguelino:new-linter-workflow
Mar 19, 2025
Merged

chore(ci): new CI workflow for linting code#41
nicomiguelino merged 4 commits intoScreenly:masterfrom
nicomiguelino:new-linter-workflow

Conversation

@nicomiguelino
Copy link
Copy Markdown
Collaborator

@nicomiguelino nicomiguelino commented Mar 19, 2025

Description

  • The workflow for running tests (test.yml) includes linting, so the step that lints the code was moved to a new workflow.
  • Runs the test and linting workflows against Node 20.x and 22.x

How Has This Been Tested?

Only GitHub Actions workflow files modified.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (where applicable).
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@nicomiguelino nicomiguelino requested a review from Copilot March 19, 2025 04:41
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR separates the linting process from the testing workflow by introducing a new lint workflow and updating the test workflow accordingly.

  • Added .github/workflows/lint.yml to run lint and format checks using Node.js 20.x and 22.x.
  • Updated .github/workflows/test.yml to remove the lint steps and adjust artifact names with a node-version suffix.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/lint.yml Introduces a dedicated lint workflow for multiple Node.js versions.
.github/workflows/test.yml Eliminates lint steps and updates artifact naming to include node version.

@nicomiguelino nicomiguelino marked this pull request as ready for review March 19, 2025 04:43
@nicomiguelino nicomiguelino merged commit 4eebb61 into Screenly:master Mar 19, 2025
5 checks passed
@nicomiguelino nicomiguelino deleted the new-linter-workflow branch March 19, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants