Skip to content

Conversation

@jeckyl
Copy link
Contributor

@jeckyl jeckyl commented Jan 6, 2019

Added option to disable a submit button

Added option to disable a submit button
Copy link
Owner

@Scritik Scritik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be improved with typeof. This way, we can juste add the disabled property without a value.

Also, do not forget to do it on ps-panel-footer-link

@Scritik Scritik changed the title Update ps-panel.tpl Add possibility to disabled panel's buttons Jan 9, 2019
@Scritik Scritik changed the title Add possibility to disabled panel's buttons Add possibility to disable panel's buttons Jan 9, 2019
@Scritik
Copy link
Owner

Scritik commented Apr 15, 2019

@jeckyl Any news?

@jeckyl
Copy link
Contributor Author

jeckyl commented Nov 4, 2019

I confirm that your change is better but then I don't know what to do with it here, knowing that it must also be applied for the code before 1.6

@Scritik
Copy link
Owner

Scritik commented Nov 14, 2019

@jeckyl I'm dropping older versions of PrestaShop to support only 1.6/1.7 so you can ignore it

@jeckyl jeckyl requested a review from Scritik January 10, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants