Repository navigation
Conversation
The first version of this patch (closed as ScrollPrize#2137) was wrong in the way the review said: it only warned when the scale transform was missing entirely, while the stores the audit reports publish an explicit [1,1,1] scale and no unit on any axis - so they passed silently. The metadata.min.json fallback the description promised was not implemented either. This replaces both: _axes_have_units() checks axes[].unit independently of the transform, _pitch_from_manifest() reads properties.pixel_size_um from the catalog (verified against the live catalog: 8.64, 2.401, and None for a store with no recorded pitch), and the tests pin the audited shape instead of the missing-transform one.
gaogao94
requested review from
bruniss,
hendrikschilling,
jrudolph and
pmh47
as code owners
October 22, 2026 01:44
|
@gaogao94 is attempting to deploy a commit to the scroll Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
tifxyz reading will be moved into vc_reader in a few days in a separate pr, which also handles this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could a maintainer add the
keep-openlabel? The last attempt (#2137) was closed by the PR time-limitrule before anyone could act on the review; this one is the corrected version, and the label is what keeps it
alive long enough to be reviewed.
What was wrong with #2137, and what changed
@pmh47 was right on all three points: the audited stores publish an explicit
[1,1,1]scale with no unit,so a check that only fires when the scale transform is missing never warns on them; and the
metadata.min.jsonfallback the description promised was not in the diff at all. Both are fixed here._axes_have_units()readsmultiscales[0].axes[].unitand is independent ofwhether a transform is present; a level-0 scale of exactly
[1, 1, 1]is also reported separately, sinceon a store whose name states a pitch that value is a placeholder rather than a measurement.
_pitch_from_manifest()resolves the store againstmetadata.min.jsonandreads
properties.pixel_size_um. When the catalog records a pitch the warning names it as the value touse; when it does not (the six legacy fragments) the warning says so instead.
[1,1,1]mustwarn, units present must stay quiet, a channel axis without a unit must not count. A test that only covers
the missing-transform case is exactly how the first version passed while doing nothing.
Calibration against the live catalog
and the published metadata of that first store is the audited shape exactly:
State of the diff: rebased onto
mainat13a88a6, 10 files, +194/-2 in the first version and thecorrections above on top; every touched file compiles and the new tests are in
lasagna/tests/. What I couldnot do is run the repository's test suite here - the dependency chain is deep enough that I could not
reproduce it - so the CI run on this PR is the check I most want, and if anything fails I will fix it.
If the reviewer's preference is a different shape - for example failing hard rather than warning when the
catalog records a pitch and the store does not - say which and I will change it; the point of the patch is to
make the audited stores impossible to miss, not to prescribe a policy.