Repository navigation
vc3d: intensity-as-alpha in overlays - #2236
Merged
Merged
Conversation
pmh47
commented
Oct 22, 2026
pmh47
commented
Member
- use overlay volume intensity as an alpha value instead of just in colormap, so base volume shows through better under ink without reducing overlay opacity excessively
- drop the overlay threshold slider in the ui, since redundant with overlay window slider
Adds an "Intensity as alpha" checkbox to the volume overlay panel. When enabled, the windowed overlay intensity is the blend alpha (transparent below the window, opaque above it, scaled by opacity). Each colormap spec gains a `premultiplied` flag: black-to-bright maps (grayscale, tints, fire, magma) blend as premultiplied colour, so tints stay bright and alpha does the darkening; other maps (viridis) blend as straight colour; label maps (glasbey) are opaque where the label is nonzero. The overlay LUT now carries per-entry alpha (vc::buildOverlayLut) and a single blend (vc::blendOverlayArgb) handles both modes; the default mode is unchanged (band-pass in window, uniform opacity). The overlay threshold spin box is removed: it only ever set window low. The agent bridge keeps `threshold` as an alias and gains `intensityAsAlpha`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…erlay threshold - Label (discrete) colormaps ignore intensity-as-alpha and always use the windowed band-pass mode. - For colormaps that are black at the low end (fire, magma, tints, grayscale), intensity-as-alpha takes alpha from the brightest colour channel, so rgb <= alpha holds and the overlay over black matches the opaque colormap. Straight maps (viridis) still use intensity as alpha. - buildOverlayLut reuses the spec and window ramp from the shared colormap LUT builder instead of resolving them again. - Remove the overlay threshold from the controller, settings, agent bridge and MCP tool; expose intensityAsAlpha through vc3d_set_overlay and regenerate rpc_description.json. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
ChaseHendrick
added a commit
to ChaseHendrick/villa
that referenced
this pull request
Oct 22, 2026
…sityAsAlpha and interpolation in viewer.set_overlay)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.