support join ... using (#1046)#1083
Open
w1ll-i-code wants to merge 1 commit into
Open
Conversation
w1ll-i-code
force-pushed
the
1046-support-join-using
branch
from
c0ac456 to
dbdebe7
Compare
Huliiiiii
approved these changes
Jun 11, 2026
Huliiiiii
reviewed
Jun 11, 2026
w1ll-i-code
force-pushed
the
1046-support-join-using
branch
2 times, most recently
from
312c252 to
cfddf11
Compare
Huliiiiii
reviewed
Jun 12, 2026
Comment on lines
+1954
to
+1958
| pub fn join_using<R, T, I>(&mut self, join: JoinType, tbl_ref: R, columns: I) -> &mut Self | ||
| where | ||
| R: IntoTableRef, | ||
| T: IntoColumnRef, | ||
| I: IntoIterator<Item = T>, |
Member
There was a problem hiding this comment.
Suggested change
| pub fn join_using<R, T, I>(&mut self, join: JoinType, tbl_ref: R, columns: I) -> &mut Self | |
| where | |
| R: IntoTableRef, | |
| T: IntoColumnRef, | |
| I: IntoIterator<Item = T>, | |
| pub fn join_using(&mut self, join: JoinType, tbl_ref: impl IntoTableRef, columns: impl IntoIterator<Item = impl IntoColumnRef>) -> &mut Self |
Does this work on sea-query's MSRV?
Author
There was a problem hiding this comment.
It does, but it'd be inconsistent with the surrounding code, which all use the explicit syntax. I still can change that, if that's the direction the project wants to take.
Member
There was a problem hiding this comment.
Using impl Trait in new code is fine. The old code was written before Rust supported this syntax.
Author
There was a problem hiding this comment.
Fixed, as well as the formatting issue in the tests. There seem to be problems with the builds however. Looks like a dependency broke.
w1ll-i-code
force-pushed
the
1046-support-join-using
branch
from
cfddf11 to
73584bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
JOIN ... USING#1046New Features
JOIN ... USING