Skip to content

Commit

Permalink
chore(topic landing): update he and en strings
Browse files Browse the repository at this point in the history
  • Loading branch information
yonadavGit committed Feb 11, 2025
1 parent a501916 commit 19c8a1f
Show file tree
Hide file tree
Showing 7 changed files with 25 additions and 14 deletions.
4 changes: 3 additions & 1 deletion static/js/NavSidebar.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -645,9 +645,11 @@ const TopicLandingTopicCatList = () => {
return(
<span data-anl-feature_name="Browse Topics">
<SidebarModule>
<span id="browseTopics">
<SidebarModuleTitle>
<span id="browseTopics">Browse Topics</span>
Browse Topics
</SidebarModuleTitle>
</span>
<div className="topic-landing-sidebar-list">
{topicCats.map((topic, i) =>
<div className="navSidebarLink ref serif" key={i}>
Expand Down
4 changes: 2 additions & 2 deletions static/js/TopicLandingPage/TopicLandingNewsletter.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const TopicLandingNewsletter = () => {
<div className="topic-landing-newsletter-wrapper" data-anl-feature_name="Newsletter Signup Form">
<div className="topic-landing-newsletter">
<h3 className="topic-landing-newsletter-text">
<InterfaceText>Stay curious. Sign up for our free Topic of the Week Newsletter.</InterfaceText>
<InterfaceText>Stay curious. Get the Timeless Topics newsletter every Tuesday.</InterfaceText>
</h3>
<div className="topic-landing-newsletter-input-wrapper">
<div className="topic-landing-newsletter-input-row">
Expand All @@ -66,7 +66,7 @@ export const TopicLandingNewsletter = () => {
ref={emailRef}
onKeyUp={handleSubscribeKeyUp}
/>
<button type="submit" onKeyUp={handleSubscribeKeyUp} onClick={handleSubscribe}>Sign Up</button>
<button type="submit" onKeyUp={handleSubscribeKeyUp} onClick={handleSubscribe}>{Sefaria._("Sign Up")}</button>
</div>
<div className="topic-landing-newsletter-input-row">
{subscribeMessage ?
Expand Down
4 changes: 2 additions & 2 deletions static/js/TopicLandingPage/TopicLandingParasha.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,10 @@ export const TopicLandingParasha = () => {
<div className="browse-all-parashot-prompt">
<a href='/topics/category/torah-portions'
data-anl-link_type="category"
data-anl-text="Browse all Parshayot"
data-anl-text="Browse All Torah Portions"
data-anl-event="navto_topic:click"
>
<InterfaceText>Browse all Parshayot</InterfaceText></a >
<InterfaceText>Browse All Torah Portions</InterfaceText></a >
</div>
</TopicLandingCalendar>
</div>
Expand Down
2 changes: 1 addition & 1 deletion static/js/TopicLandingPage/TopicLandingSearch.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ const renderInput = (openTopic, numOfTopics, highlightedIndex, highlightedSugges
highlightedIndex >= 0 && openTopic(highlightedSuggestion.slug)
}
};
const placeHolder = Sefaria._v({"he": `חפש ${numOfTopics} אנשים, מקומות, חפצים`, "en": `Find ${numOfTopics} People, Places, Things`})
const placeHolder = Sefaria._v({"he": `תתחילו להתעניין! ${numOfTopics} נושאים מ-א׳ עד ת׳`, "en": `Find ${numOfTopics} Topics A-Z`})
return (
<div className="topic-landing-search-input-box-wrapper">
<SearchButton/>
Expand Down
2 changes: 1 addition & 1 deletion static/js/TopicLandingPage/TopicLandingSeasonal.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export const TopicLandingSeasonal = () => {
return (
<div className='topic-landing-seasonal' data-anl-feature_name="Calendar">
<TopicLandingCalendar
header={<InterfaceText>From the Jewish Calendar</InterfaceText>}
header={<InterfaceText>On the Jewish Calendar</InterfaceText>}
title={title}
description={description}
link={link}
Expand Down
2 changes: 1 addition & 1 deletion static/js/TopicLandingPage/TopicsLandingPage.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const TopicsLandingPage = ({openTopic}) => {
{type: "TopicLandingTrendingTopics"},
{type: "AZTopicsLink"},
];
const pageTitle = "Let Your Curiosity Lead The Way"
const pageTitle = "Explore by Topic"
return (
<div className="readerNavMenu" key="0"
data-anl-project="topics"
Expand Down
21 changes: 15 additions & 6 deletions static/js/sefaria/strings.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,10 @@ const Strings = {
"Add a description.": "הוסף תיאור",
"Add a title.": "הוסף שם כותר",
"Explore Jewish Texts by Topic": "עיון בארון הספרים היהודי לפי נושא",
"Explore by Topic": "לימוד לפי נושאים",
"Explore by Topic": "למדו לפי נושא",
"About Topics": "אודות \"נושאים\"",
"Trending Topics": "נושאים נפוצים",
"More": "עוד",
"Less": "פחות",
"All Topics A-Z": "כל הנושאים א-ת",
"Browse or search our complete list of topics.": "חיפוש ברשימת הנושאים.",
"Create a Topic": "ליצירת נושא חדש",
"Edit Topic": "עריכת נושא",
Expand Down Expand Up @@ -115,7 +113,20 @@ const Strings = {
"Illustrative image" : "תמונה להמחשה",

// Topic Landing Page
"Featured Topic": "Featured Topic",
"Featured Topic": "נושא לדוגמא",
"Go to topic ›": "לפתיחת הנושא ›",
"Stay curious. Get the Timeless Topics newsletter every Tuesday.": "אל תפספסו את החדשות המרעישות! הירשמו למיילים של ספריא כדי לקבל עדכונים על מקורות, כותרים וכלים חדשים.",
"Learn more about": "למדו עוד על",
"Read the Portion": "לקריאת הפרשה",
"On the Jewish Calendar": "מועדים קרובים בלוח השנה העברי",
"Explore the Jewish Calendar": "לעוד מועדים בלוח השנה העברי",
"Browse Topics": "לדפדוף בנושאים השונים",
"Trending Topics": "נושאים פופולריים",
"All Topics A-Z ›": "כל הנושאים מא׳ עד ת׳ ›",
"Browse All Torah Portions": "לרשימת כל הפרשות",
"First Name": "שם פרטי",
"Last Name": "שם משפחה",
"Explore": "למדו עוד על",

// Community Page
"From the Community: Today on Sefaria": "מן הקהילה: היום בספריא",
Expand Down Expand Up @@ -464,7 +475,6 @@ const Strings = {
"by": "על ידי",
"based on": "ע“פ",
"research of Dr. Michael Sperling": "המחקר של ד\"ר מיכאל ספרלינג",
"Read the Portion": "קראו את הפרשה",
"My Notes": "הרשומות שלי",
"Updates": "עדכונים",
"Preferred Translation": "תרגום מועדף",
Expand Down Expand Up @@ -557,7 +567,6 @@ const Strings = {
"This Week’s Torah Portion": "פרשת השבוע",
"Learn More on": "לקריאה נוספת על",
"Learn More about": "לקריאה נוספת על",
"Read the Portion": "לקריאת הפרשה",
"Browse all Parshayot": "לצפייה בכל הפרשות",
"From the Jewish Calendar": "מלוח השנה",

Expand Down

0 comments on commit 19c8a1f

Please sign in to comment.