Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic landing #2122

Merged
merged 678 commits into from
Feb 13, 2025
Merged

Topic landing #2122

merged 678 commits into from
Feb 13, 2025

Conversation

nsantacruz
Copy link
Contributor

Description

A brief description of the PR

Code Changes

The following changes were made to the files below

Notes

Any additional notes go here

nsantacruz and others added 30 commits November 27, 2024 10:43
@nsantacruz
Merge branch 'topic-landing' of https://github.com/Sefaria/Sefaria-Pr…
d2796e6 
…oject into topic-landing
@yonadavGit
refactor(ref autocomplete): deprecate ref autocomplete
39f0ef0
@yonadavGit
Merge pull request #2125 from Sefaria/chore/sc-30080/modifications-to…
9106f02 
…-name-api-with-pools

Generalize name_api and connect it to topic autocomplete
@nsantacruz
feat(topics): add column with sefaria link
a7c4cf6
@nsantacruz
Merge branch 'topic-landing' of https://github.com/Sefaria/Sefaria-Pr…
14df17e 
…oject into topic-landing
@nsantacruz
feat(topics): make display data prefix/suffix editable
9905725
@nsantacruz
Merge branch 'master' into topic-landing
125c743
@nsantacruz
Merge branch 'master' into topic-landing
8713ec3
@nsantacruz
test(topics): add test for topic of the day
97f3466
@nsantacruz
feat(topics): add topic of the day api
c22abe4
@nsantacruz
chore(topics): remove unnecessary django setup now that we have pytes…
f6e6959 
…t-django
@nsantacruz
chore(topics): add pytest django as a dependency
b7bea0c
@nsantacruz
chore(topics): add topic of the day function in Sefaria to call corre…
2b39b16 
…sponding API
@nsantacruz
feat(topics): basic topic of the day rendering
9219d5c
@nsantacruz
feat(topics): add ImageWithAltText
347167a
@nsantacruz
feat(topics): topic of the day frontend WIP
d7f8846
@yonadavGit
feat(Topic Salad): basic implementation of WordSalad component by a n…
6e55702 
…ew helper npm library 'line-clamp'
@yonadavGit
feat(Topic Salad): implementation of the salad without external libra…
844f4ad 
…ries using pure css line-clamp
@yonadavGit
feat(Topic Salad): change to required font
9136d91
@yonadavGit
chore: merge
ff96ecf
@nsantacruz
fix(topics): change text transform
633c801
@nsantacruz
fix(topics): fix bad find and replace
b9a7a2d
@yonadavGit
feat(Topic Salad): create the TopicSalad component
f95f360
@nsantacruz
Merge branch 'topic-landing' into topic-landing-tod
c786ba1
@nsantacruz
feat(topics): basic layout of topic landing page
5f51398
@nsantacruz
chore(topics): merge
c4474f3
@yonadavGit
feat(Topic Pools): create sefaria.js function to interact with endpoint
daf59ee
@yonadavGit
Merge remote-tracking branch 'origin/topic-landing' into topic-landing
4949f36
@yonadavGit
chore: merge
0edf043
@yonadavGit
feat(Topic Landing Page): turn content container into flex box and ce…
6a6d9b7 
…nter child elements
yonadavGit and others added 23 commits February 6, 2025 13:52
@yonadavGit
Merge pull request #2308 from Sefaria/topics_pd_dataframe
7ed2ee4 
Topics pd dataframe
@edamboritz
Revert "Topics pd dataframe"
7608a28
@edamboritz
Merge pull request #2310 from Sefaria/revert-2308-topics_pd_dataframe
6e87fae 
Revert "Topics pd dataframe"
@yonadavGit
feat(topic landing): add navToTopic analytics event for all features
88bb4a9
@yonadavGit
feat(topic landing): queryset level slicing and sampling
ce78950
@yonadavGit
Merge pull request #2314 from Sefaria/faster-querying-of-random-topic…
8f5c241 
…s-by-pool

Optimize topic sampling with queryset slicing
@yonadavGit
chore(topic landing): add missing events
772f162
@yonadavGit
fix(topic landing): add missing analytics event
ceb87bf
@yonadavGit
fix(topic landing): make lang a 'unique together' param for featured …
6f2ea00 
…topic
@yonadavGit
Merge pull request #2315 from Sefaria/bug/sc-32328/impossible-to-sche…
7c8cbd8 
…dule-same-featured-topic

add 'lang' to unique constraint for featured topics
@yonadavGit
fix(topic landing): add missing analytics event
94ae8bd
@yonadavGit
merge topic-landing
979bd23
@yonadavGit
fix(topic landing): add space between # and search suggestion
0725aff
@yonadavGit
fix(topic landing): polish multi cards ui
447b682
@yonadavGit
fix(topic landing): truncate card title
67f5d0d
@yonadavGit
fix(topic landing): fix line-height
890870b
@yonadavGit
Merge pull request #2319 from Sefaria/feature/sc-32349/truncate-multi…
93fe7e9 
…-cards-descriptions

Polish multi cards for topic landing
@yonadavGit
chore(topic landing): cleaner analytics for card
c45619c
@yonadavGit
Merge pull request #2313 from Sefaria/chore/sc-31254/analytics-on-new…
a501916 
…-topic-landing-page

Analytics for Topic Landing
@yonadavGit
chore(topic landing): update he and en strings
19c8a1f
@yonadavGit
chore(topic landing): polish multi cards hebrew ui
2c8cea5
@yonadavGit
chore(topic landing): num of topics to locale string
0e9d351
@yonadavGit
feat(topic landing): display new topic landing page when admin is logged
f5c38c3
@yonadavGit yonadavGit requested a review from akiva10b February 11, 2025 16:48
@yonadavGit yonadavGit marked this pull request as ready for review February 11, 2025 16:48
@akiva10b akiva10b merged commit 08baee5 into master Feb 13, 2025
44 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akiva10b akiva10b Awaiting requested review from akiva10b

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nsantacruz @akiva10b @yonadavGit @saengel @edamboritz