[rb] Add support for beta chrome

[aguspe]

User description

Motivation and Context

The purpose of this PR is to add the ability for ruby tests to run using chrome-beta to make it easier to debug

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

---

PR Type

Enhancement, Tests

---

Description

• Added support for running tests with Chrome Beta.

• Introduced chrome_beta method to configure Chrome Beta driver.

• Updated Bazel build files to include Chrome Beta configuration.

• Enhanced test environment to handle Chrome Beta driver setup.

---

Changes walkthrough 📝

	Relevant files
Enhancement	test_environment.rb Add Chrome Beta driver support in test environment              rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb Added chrome_beta method to configure Chrome Beta driver. Modified create_driver! to handle Chrome Beta driver. Adjusted driver method selection logic for Chrome Beta. +8/-1
Configuration changes	tests.bzl Add Chrome Beta configuration to Bazel tests                          rb/spec/tests.bzl Added Chrome Beta configuration to Bazel test definitions. Included environment variables for Chrome Beta setup. Configured Chrome Beta dependencies and data. +23/-0    BUILD.bazel Include Chrome Beta in supported browsers list                      rb/spec/integration/BUILD.bazel Added chrome-beta to the list of supported browsers. +1/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Method Naming The chrome_beta method modifies the @driver instance variable to :chrome but the PR is adding support for :chrome_beta. This might cause inconsistency in driver identification. def chrome_beta(opts = {}) @driver = :chrome opts[:browser_version] = 'beta' end Configuration Mismatch The Bazel configuration uses chrome-beta (with hyphen) while the Ruby code uses :chrome_beta (with underscore). This naming inconsistency could lead to integration issues. "chrome-beta": { "data": chrome_data, "deps": ["//rb/lib/selenium/webdriver:chrome"], "tags": [], "target_compatible_with": [], "env": { "WD_REMOTE_BROWSER": "chrome", "WD_SPEC_DRIVER": "chrome-beta", } | select({ "@selenium//common:use_pinned_linux_chrome": { "CHROME_BINARY": "$(location @linux_chrome//:chrome-linux64/chrome)", "CHROMEDRIVER_BINARY": "$(location @linux_chromedriver//:chromedriver)", }, "@selenium//common:use_pinned_macos_chrome": { "CHROME_BINARY": "$(location @mac_chrome//:Chrome.app)/Contents/MacOS/Chrome", "CHROMEDRIVER_BINARY": "$(location @mac_chromedriver//:chromedriver)", }, "//conditions:default": {}, }) | select({ "@selenium//common:use_headless_browser": {"HEADLESS": "true"}, "//conditions:default": {}, }), },

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	✅ Fix driver initialization parameter Suggestion Impact: The commit addressed the issue differently by restructuring the code to properly handle the chrome_beta driver case. Instead of passing 'method' to WebDriver::Driver.for, it now sets 'method = driver' for non-chrome_beta cases, which effectively implements the suggestion's intent in a different way. code diff: + if driver == :chrome_beta + opts[:browser_version] = 'beta' + method = :chrome_driver + else + method = driver + end The WebDriver::Driver.for method should receive the driver symbol, not the method symbol. You're passing method instead of driver, which will cause an error when trying to initialize non-private driver methods. rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb [166-176] def create_driver!(listener: nil, **opts, &block) check_for_previous_error chrome_beta(opts) if driver == :chrome_beta method = :"#{driver}_driver" instance = if private_methods.include?(method) send(method, listener: listener, options: build_options(**opts)) else - WebDriver::Driver.for(method, listener: listener, options: build_options(**opts)) + WebDriver::Driver.for(driver, listener: listener, options: build_options(**opts)) end [Suggestion has been applied] Suggestion importance[1-10]: 10 __ Why: This is a critical bug fix. The PR incorrectly changed the parameter from driver to method in the WebDriver::Driver.for call, which would cause the driver initialization to fail for non-private driver methods. The suggestion correctly restores the original parameter.	High
Update

[titusfortner]

I like what you've done with most of this.

I keep going back and forth on if we want to pass chrome_beta or if we want to have a WD_BROWSER_VERSION environment variable for "stable" and "beta". I did the review thinking the former, and now I'm thinking the latter would be better. Mostly I care about adding: guards.add_condition(:version, GlobalTestEnv.version) which would allow us to do guards of except: {browser: :chrome, version: :stable}

I wonder if we should start with adjusting the firefox beta Ruby implementation to do what we want then we can copy it with the chrome.

[aguspe]

I like what you've done with most of this.

I keep going back and forth on if we want to pass chrome_beta or if we want to have a WD_BROWSER_VERSION environment variable for "stable" and "beta". I did the review thinking the former, and now I'm thinking the latter would be better. Mostly I care about adding: guards.add_condition(:version, GlobalTestEnv.version) which would allow us to do guards of except: {browser: :chrome, version: :stable}

I wonder if we should start with adjusting the firefox beta Ruby implementation to do what we want then we can copy it with the chrome.

Thank you @titusfortner for the review! appreciated, I'm trying to addressed the comments today and tomorrow, I will be resolving the remaining ones until it works and ping you for a review again :)