[build] allow tests tagged exclusive-if-local to run on rbe #15483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titusfortner
added
C-rb
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
CI Feedback 🧐(Feedback updated until commit 09533e7)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
|
Hmm, should the alerts automatically disappear? Is this a bug. @pujagani do other bindings have this issue? Also @aguspe, what isn't updating on remote? (in case there is confusion, "remote" tags in Ruby guards is for tests running on "grid" not "rbe"). Sorry I'm not diving deep into these right now, we can discuss more later if we need. |
No problem @titusfortner I will try to give it a look tonight but I noticed that this test pass locally but fails in RBE and I wanted to investigate it properly, if this is not urgent I can take the time The same with the alerts flickering, it only happens in chromium based sessions, in firefox it works fine, but I do not know the root cause so I need to investigate more |
|
Look at the spec helper for what guard conditions have been added for this project. Rbe has its own guard. |
|
/help |
PR Agent Walkthrough 🤖Welcome to the PR Agent, an AI-powered tool for automated pull request analysis, feedback, suggestions and more. Here is a list of tools you can use to interact with the PR Agent:
(1) Note that each tool can be triggered automatically when a new PR is opened, or called manually by commenting on a PR. (2) Tools marked with [*] require additional parameters to be passed. For example, to invoke the |
|
/config |
🛠️ Wiki configuration file settings:🛠️ Local configuration file settings:
🛠️ Global configuration file settings:🛠️ PR-Agent final configurations:==================== CONFIG ====================
config.enable_custom_labels = False
config.model = 'claude-3-7-sonnet-20250219'
config.model_turbo = 'gpt-4o-2024-11-20'
config.fallback_models = ['gpt-4o-2024-11-20']
config.git_provider = 'github'
config.publish_output = True
config.publish_output_no_suggestions = True
config.publish_output_progress = True
config.verbosity_level = 0
config.use_extra_bad_extensions = False
config.publish_logs = False
config.use_wiki_settings_file = True
config.use_repo_settings_file = True
config.use_global_settings_file = True
config.disable_auto_feedback = False
config.ai_timeout = 120
config.response_language = 'en-US'
config.patch_extension_skip_types = ['.md', '.txt']
config.extra_allowed_extensions = []
config.allow_dynamic_context = True
config.max_extra_lines_before_dynamic_context = 10
config.patch_extra_lines_before = 5
config.patch_extra_lines_after = 1
config.cli_mode = False
config.calculate_context = True
config.disable_checkboxes = False
config.output_relevant_configurations = False
config.large_patch_policy = 'clip'
config.seed = -1
config.temperature = 0.2
config.allow_dynamic_context_ab_testing = False
config.choose_dynamic_context_ab_testing_ratio = 0.5
config.ignore_pr_title = ['^\\[Auto\\]', '^Auto']
config.ignore_pr_target_branches = []
config.ignore_pr_source_branches = []
config.ignore_pr_labels = []
config.allow_only_specific_folders = []
config.ignore_pr_authors = []
config.is_auto_command = False
config.enable_ai_metadata = True
config.present_reasoning = True
config.max_tickets = 10
config.max_tickets_chars = 8000
config.prevent_any_approval = False
config.enable_comment_approval = False
config.enable_auto_approval = False
config.auto_approve_for_low_review_effort = -1
config.auto_approve_for_no_suggestions = False
==================== PR_REVIEWER ====================
pr_reviewer.require_score_review = False
pr_reviewer.require_tests_review = True
pr_reviewer.require_estimate_effort_to_review = True
pr_reviewer.require_can_be_split_review = False
pr_reviewer.require_security_review = True
pr_reviewer.require_ticket_analysis_review = True
pr_reviewer.extra_issue_links = False
pr_reviewer.persistent_comment = True
pr_reviewer.extra_instructions = ''
pr_reviewer.final_update_message = True
pr_reviewer.enable_review_labels_security = True
pr_reviewer.enable_review_labels_effort = True
pr_reviewer.require_all_thresholds_for_incremental_review = False
pr_reviewer.minimal_commits_for_incremental_review = 0
pr_reviewer.minimal_minutes_for_incremental_review = 0
pr_reviewer.enable_intro_text = True
pr_reviewer.enable_help_text = False
pr_reviewer.max_number_of_rag_issues_rag_enabled = 2
==================== PR_DESCRIPTION ====================
pr_description.publish_labels = False
pr_description.add_original_user_description = True
pr_description.generate_ai_title = False
pr_description.extra_instructions = ''
pr_description.enable_pr_type = True
pr_description.final_update_message = True
pr_description.enable_help_text = False
pr_description.enable_help_comment = True
pr_description.bring_latest_tag = False
pr_description.publish_description_as_comment = False
pr_description.publish_description_as_comment_persistent = True
pr_description.enable_semantic_files_types = True
pr_description.collapsible_file_list = 'adaptive'
pr_description.collapsible_file_list_threshold = 6
pr_description.inline_file_summary = False
pr_description.use_description_markers = False
pr_description.include_generated_by_header = True
pr_description.enable_large_pr_handling = True
pr_description.max_ai_calls = 4
pr_description.async_ai_calls = True
==================== PR_QUESTIONS ====================
pr_questions.enable_help_text = False
==================== PR_CODE_SUGGESTIONS ====================
pr_code_suggestions.commitable_code_suggestions = False
pr_code_suggestions.dual_publishing_score_threshold = -1
pr_code_suggestions.focus_only_on_problems = True
pr_code_suggestions.allow_thumbs_up_down = False
pr_code_suggestions.enable_more_suggestions_checkbox = True
pr_code_suggestions.extra_instructions = ''
pr_code_suggestions.enable_help_text = False
pr_code_suggestions.enable_chat_text = False
pr_code_suggestions.enable_intro_text = True
pr_code_suggestions.persistent_comment = True
pr_code_suggestions.max_history_len = 4
pr_code_suggestions.apply_suggestions_checkbox = True
pr_code_suggestions.suggestions_score_threshold = 0
pr_code_suggestions.new_score_mechanism = True
pr_code_suggestions.new_score_mechanism_th_high = 9
pr_code_suggestions.new_score_mechanism_th_medium = 7
pr_code_suggestions.num_code_suggestions_per_chunk = 3
pr_code_suggestions.max_number_of_calls = 3
pr_code_suggestions.parallel_calls = True
pr_code_suggestions.final_clip_factor = 0.8
pr_code_suggestions.decouple_hunks = False
pr_code_suggestions.demand_code_suggestions_self_review = False
pr_code_suggestions.code_suggestions_self_review_text = '**Author self-review**: I have reviewed the PR code suggestions, and addressed the relevant ones.'
pr_code_suggestions.approve_pr_on_self_review = False
pr_code_suggestions.fold_suggestions_on_self_review = True
pr_code_suggestions.publish_post_process_suggestion_impact = True
pr_code_suggestions.wiki_page_accepted_suggestions = True
==================== PR_CUSTOM_PROMPT ====================
pr_custom_prompt.prompt = 'The code suggestions should focus only on the following:\n- ...\n- ...\n...\n'
pr_custom_prompt.suggestions_score_threshold = 0
pr_custom_prompt.num_code_suggestions_per_chunk = 4
pr_custom_prompt.self_reflect_on_custom_suggestions = True
pr_custom_prompt.enable_help_text = False
==================== PR_ADD_DOCS ====================
pr_add_docs.extra_instructions = ''
pr_add_docs.docs_style = 'Sphinx'
pr_add_docs.file = ''
pr_add_docs.class_name = ''
==================== PR_UPDATE_CHANGELOG ====================
pr_update_changelog.push_changelog_changes = False
pr_update_changelog.extra_instructions = ''
pr_update_changelog.add_pr_link = True
==================== PR_ANALYZE ====================
pr_analyze.enable_help_text = True
==================== PR_TEST ====================
pr_test.extra_instructions = ''
pr_test.testing_framework = ''
pr_test.num_tests = 3
pr_test.avoid_mocks = True
pr_test.file = ''
pr_test.class_name = ''
pr_test.enable_help_text = False
==================== PR_IMPROVE_COMPONENT ====================
pr_improve_component.num_code_suggestions = 4
pr_improve_component.extra_instructions = ''
pr_improve_component.file = ''
pr_improve_component.class_name = ''
==================== PR_HELP ====================
pr_help.force_local_db = False
pr_help.num_retrieved_snippets = 5
==================== PR_NEW_ISSUE ====================
pr_new_issue.label_to_prompt_part = {'general': 'general question', 'feature': 'feature request (may already be addressed in the documentation)', 'bug': 'possible bug report (may be a by design behavior)'}
pr_new_issue.supported_repos = ['qodo-ai/pr-agent']
==================== PR_HELP_DOCS ====================
pr_help_docs.repo_url = ''
pr_help_docs.repo_default_branch = 'main'
pr_help_docs.docs_path = 'docs'
pr_help_docs.exclude_root_readme = False
pr_help_docs.supported_doc_exts = ['.md', '.mdx', '.rst']
pr_help_docs.enable_help_text = False
==================== PR_SIMILAR_ISSUE ====================
pr_similar_issue.skip_comments = False
pr_similar_issue.force_update_dataset = False
pr_similar_issue.max_issues_to_scan = 500
pr_similar_issue.vectordb = 'pinecone'
==================== PR_FIND_SIMILAR_COMPONENT ====================
pr_find_similar_component.class_name = ''
pr_find_similar_component.file = ''
pr_find_similar_component.search_from_org = False
pr_find_similar_component.allow_fallback_less_words = True
pr_find_similar_component.number_of_results = 5
==================== BEST_PRACTICES ====================
best_practices.content = ''
best_practices.organization_name = ''
best_practices.max_lines_allowed = 800
best_practices.enable_global_best_practices = False
best_practices.allow_repo_best_practices = True
==================== AUTO_BEST_PRACTICES ====================
auto_best_practices.enable_auto_best_practices = True
auto_best_practices.utilize_auto_best_practices = True
auto_best_practices.extra_instructions = ''
auto_best_practices.content = '<b>Pattern 1: Add null checks for potentially null parameters and properties before using them to prevent NullReferenceExceptions. Always validate that parameters and properties are not null before accessing their members or methods.</b>\n\nExample code before:\n```\npublic Task SendAsJsonAsync<T>(T command, JsonSerializerContext jsonSerializerContext)\n{\n return transport.SendJsonAsync(command.ToString());\n}\n```\n\nExample code after:\n```\npublic Task SendAsJsonAsync<T>(T command, JsonSerializerContext jsonSerializerContext)\n{\n ArgumentNullException.ThrowIfNull(command, nameof(command));\n ArgumentNullException.ThrowIfNull(jsonSerializerContext, nameof(jsonSerializerContext));\n return transport.SendJsonAsync(command.ToString());\n}\n```\n\n\n\n\n___\n\n\n<b>Pattern 2: Use null-conditional operators (?.) and null-coalescing operators (??) instead of null-forgiving operators (!) to safely handle potentially null values and provide default values when needed.</b>\n\nExample code before:\n```\nreturn commandResponse.Value.ToString()!;\n```\n\nExample code after:\n```\nreturn commandResponse.Value?.ToString() ?? string.Empty;\n```\n\n\n\n\n___\n\n\n<b>Pattern 3: Initialize collections and properties with safe default values instead of null to prevent potential NullReferenceExceptions when the collections are accessed or modified later.</b>\n\nExample code before:\n```\npublic Func<HttpRequestData, bool> RequestMatcher { get; set; } = null!;\n```\n\nExample code after:\n```\npublic Func<HttpRequestData, bool> RequestMatcher { get; set; } = _ => false;\n```\n\n\n\n\n___\n\n\n<b>Pattern 4: Improve error message clarity by providing specific details about the error context, including the actual values that caused the error and clear instructions for resolution.</b>\n\nExample code before:\n```\nthrow new Error(`Params must be an instance of PartitionDescriptor. Received:\'${partition}\'`);\n```\n\nExample code after:\n```\nthrow new Error(`Params must be an instance of BrowsingContextPartitionDescriptor or StorageKeyPartitionDescriptor. Received:\'${partition}\'`);\n```\n\n\n\n\n___\n\n\n<b>Pattern 5: Use locale-independent string formatting for numeric values to ensure consistent behavior across different system locales, especially when formatting command-line arguments.</b>\n\nExample code before:\n```\nargs.add(String.format("--port=%d", getPort()));\n```\n\nExample code after:\n```\nargs.add("--port=" + String.valueOf(getPort()));\n```\n\n\n\n\n___\n'
auto_best_practices.min_suggestions_to_auto_best_practices = 10
auto_best_practices.number_of_days_to_update = 30
auto_best_practices.max_patterns = 5
auto_best_practices.minimal_date_to_update = '2025-01-26'
auto_best_practices.found_auto_best_practices = True
auto_best_practices.generate_new_best_practices = False
==================== github_app ====================
github_app.bot_user = 'github-actions[bot]'
github_app.override_deployment_type = True
github_app.handle_pr_actions = ['opened', 'reopened', 'ready_for_review']
github_app.pr_commands = ['/describe --pr_description.final_update_message=false', '/review', '/improve']
github_app.handle_push_trigger = False
github_app.push_commands = ['/describe', '/review']
github_app.ignore_pr_title = []
github_app.ignore_bot_pr = True |
|
/config |
🛠️ Wiki configuration file settings:🛠️ Local configuration file settings:
🛠️ Global configuration file settings:🛠️ PR-Agent final configurations:==================== PR_REVIEWER ====================
pr_reviewer.require_score_review = False
pr_reviewer.require_tests_review = True
pr_reviewer.require_estimate_effort_to_review = True
pr_reviewer.require_can_be_split_review = False
pr_reviewer.require_security_review = True
pr_reviewer.require_ticket_analysis_review = True
pr_reviewer.extra_issue_links = False
pr_reviewer.persistent_comment = True
pr_reviewer.extra_instructions = ''
pr_reviewer.final_update_message = True
pr_reviewer.enable_review_labels_security = True
pr_reviewer.enable_review_labels_effort = True
pr_reviewer.require_all_thresholds_for_incremental_review = False
pr_reviewer.minimal_commits_for_incremental_review = 0
pr_reviewer.minimal_minutes_for_incremental_review = 0
pr_reviewer.enable_intro_text = True
pr_reviewer.enable_help_text = False
pr_reviewer.max_number_of_rag_issues_rag_enabled = 2
==================== PR_DESCRIPTION ====================
pr_description.publish_labels = False
pr_description.add_original_user_description = True
pr_description.generate_ai_title = False
pr_description.extra_instructions = ''
pr_description.enable_pr_type = True
pr_description.final_update_message = True
pr_description.enable_help_text = False
pr_description.enable_help_comment = True
pr_description.bring_latest_tag = False
pr_description.publish_description_as_comment = False
pr_description.publish_description_as_comment_persistent = True
pr_description.enable_semantic_files_types = True
pr_description.collapsible_file_list = 'adaptive'
pr_description.collapsible_file_list_threshold = 6
pr_description.inline_file_summary = False
pr_description.use_description_markers = False
pr_description.include_generated_by_header = True
pr_description.enable_large_pr_handling = True
pr_description.max_ai_calls = 4
pr_description.async_ai_calls = True
==================== PR_QUESTIONS ====================
pr_questions.enable_help_text = False
==================== PR_CODE_SUGGESTIONS ====================
pr_code_suggestions.commitable_code_suggestions = False
pr_code_suggestions.dual_publishing_score_threshold = -1
pr_code_suggestions.focus_only_on_problems = True
pr_code_suggestions.allow_thumbs_up_down = False
pr_code_suggestions.enable_more_suggestions_checkbox = True
pr_code_suggestions.extra_instructions = ''
pr_code_suggestions.enable_help_text = False
pr_code_suggestions.enable_chat_text = False
pr_code_suggestions.enable_intro_text = True
pr_code_suggestions.persistent_comment = True
pr_code_suggestions.max_history_len = 4
pr_code_suggestions.apply_suggestions_checkbox = True
pr_code_suggestions.suggestions_score_threshold = 0
pr_code_suggestions.new_score_mechanism = True
pr_code_suggestions.new_score_mechanism_th_high = 9
pr_code_suggestions.new_score_mechanism_th_medium = 7
pr_code_suggestions.num_code_suggestions_per_chunk = 3
pr_code_suggestions.max_number_of_calls = 3
pr_code_suggestions.parallel_calls = True
pr_code_suggestions.final_clip_factor = 0.8
pr_code_suggestions.decouple_hunks = False
pr_code_suggestions.demand_code_suggestions_self_review = False
pr_code_suggestions.code_suggestions_self_review_text = '**Author self-review**: I have reviewed the PR code suggestions, and addressed the relevant ones.'
pr_code_suggestions.approve_pr_on_self_review = False
pr_code_suggestions.fold_suggestions_on_self_review = True
pr_code_suggestions.publish_post_process_suggestion_impact = True
pr_code_suggestions.wiki_page_accepted_suggestions = True
==================== PR_CUSTOM_PROMPT ====================
pr_custom_prompt.prompt = 'The code suggestions should focus only on the following:\n- ...\n- ...\n...\n'
pr_custom_prompt.suggestions_score_threshold = 0
pr_custom_prompt.num_code_suggestions_per_chunk = 4
pr_custom_prompt.self_reflect_on_custom_suggestions = True
pr_custom_prompt.enable_help_text = False
==================== PR_ADD_DOCS ====================
pr_add_docs.extra_instructions = ''
pr_add_docs.docs_style = 'Sphinx'
pr_add_docs.file = ''
pr_add_docs.class_name = ''
==================== PR_UPDATE_CHANGELOG ====================
pr_update_changelog.push_changelog_changes = False
pr_update_changelog.extra_instructions = ''
pr_update_changelog.add_pr_link = True
==================== PR_ANALYZE ====================
pr_analyze.enable_help_text = True
==================== PR_TEST ====================
pr_test.extra_instructions = ''
pr_test.testing_framework = ''
pr_test.num_tests = 3
pr_test.avoid_mocks = True
pr_test.file = ''
pr_test.class_name = ''
pr_test.enable_help_text = False
==================== PR_IMPROVE_COMPONENT ====================
pr_improve_component.num_code_suggestions = 4
pr_improve_component.extra_instructions = ''
pr_improve_component.file = ''
pr_improve_component.class_name = ''
==================== PR_HELP ====================
pr_help.force_local_db = False
pr_help.num_retrieved_snippets = 5
==================== PR_NEW_ISSUE ====================
pr_new_issue.label_to_prompt_part = {'general': 'general question', 'feature': 'feature request (may already be addressed in the documentation)', 'bug': 'possible bug report (may be a by design behavior)'}
pr_new_issue.supported_repos = ['qodo-ai/pr-agent']
==================== PR_HELP_DOCS ====================
pr_help_docs.repo_url = ''
pr_help_docs.repo_default_branch = 'main'
pr_help_docs.docs_path = 'docs'
pr_help_docs.exclude_root_readme = False
pr_help_docs.supported_doc_exts = ['.md', '.mdx', '.rst']
pr_help_docs.enable_help_text = False
==================== PR_SIMILAR_ISSUE ====================
pr_similar_issue.skip_comments = False
pr_similar_issue.force_update_dataset = False
pr_similar_issue.max_issues_to_scan = 500
pr_similar_issue.vectordb = 'pinecone'
==================== PR_FIND_SIMILAR_COMPONENT ====================
pr_find_similar_component.class_name = ''
pr_find_similar_component.file = ''
pr_find_similar_component.search_from_org = False
pr_find_similar_component.allow_fallback_less_words = True
pr_find_similar_component.number_of_results = 5
==================== BEST_PRACTICES ====================
best_practices.content = ''
best_practices.organization_name = ''
best_practices.max_lines_allowed = 800
best_practices.enable_global_best_practices = False
best_practices.allow_repo_best_practices = True
==================== AUTO_BEST_PRACTICES ====================
auto_best_practices.enable_auto_best_practices = True
auto_best_practices.utilize_auto_best_practices = True
auto_best_practices.extra_instructions = ''
auto_best_practices.content = '<b>Pattern 1: Add null checks for potentially null parameters and properties before using them to prevent NullReferenceExceptions. Always validate that parameters and properties are not null before accessing their members or methods.</b>\n\nExample code before:\n```\npublic Task SendAsJsonAsync<T>(T command, JsonSerializerContext jsonSerializerContext)\n{\n return transport.SendJsonAsync(command.ToString());\n}\n```\n\nExample code after:\n```\npublic Task SendAsJsonAsync<T>(T command, JsonSerializerContext jsonSerializerContext)\n{\n ArgumentNullException.ThrowIfNull(command, nameof(command));\n ArgumentNullException.ThrowIfNull(jsonSerializerContext, nameof(jsonSerializerContext));\n return transport.SendJsonAsync(command.ToString());\n}\n```\n\n\n\n\n___\n\n\n<b>Pattern 2: Use null-conditional operators (?.) and null-coalescing operators (??) instead of null-forgiving operators (!) to safely handle potentially null values and provide default values when needed.</b>\n\nExample code before:\n```\nreturn commandResponse.Value.ToString()!;\n```\n\nExample code after:\n```\nreturn commandResponse.Value?.ToString() ?? string.Empty;\n```\n\n\n\n\n___\n\n\n<b>Pattern 3: Initialize collections and properties with safe default values instead of null to prevent potential NullReferenceExceptions when the collections are accessed or modified later.</b>\n\nExample code before:\n```\npublic Func<HttpRequestData, bool> RequestMatcher { get; set; } = null!;\n```\n\nExample code after:\n```\npublic Func<HttpRequestData, bool> RequestMatcher { get; set; } = _ => false;\n```\n\n\n\n\n___\n\n\n<b>Pattern 4: Improve error message clarity by providing specific details about the error context, including the actual values that caused the error and clear instructions for resolution.</b>\n\nExample code before:\n```\nthrow new Error(`Params must be an instance of PartitionDescriptor. Received:\'${partition}\'`);\n```\n\nExample code after:\n```\nthrow new Error(`Params must be an instance of BrowsingContextPartitionDescriptor or StorageKeyPartitionDescriptor. Received:\'${partition}\'`);\n```\n\n\n\n\n___\n\n\n<b>Pattern 5: Use locale-independent string formatting for numeric values to ensure consistent behavior across different system locales, especially when formatting command-line arguments.</b>\n\nExample code before:\n```\nargs.add(String.format("--port=%d", getPort()));\n```\n\nExample code after:\n```\nargs.add("--port=" + String.valueOf(getPort()));\n```\n\n\n\n\n___\n'
auto_best_practices.min_suggestions_to_auto_best_practices = 10
auto_best_practices.number_of_days_to_update = 30
auto_best_practices.max_patterns = 5
auto_best_practices.minimal_date_to_update = '2025-01-26'
auto_best_practices.found_auto_best_practices = True
auto_best_practices.generate_new_best_practices = False
==================== CONFIG ====================
config.enable_custom_labels = True
config.model = 'claude-3-7-sonnet-20250219'
config.model_turbo = 'gpt-4o-2024-11-20'
config.fallback_models = ['gpt-4o-2024-11-20']
config.git_provider = 'github'
config.publish_output = True
config.publish_output_no_suggestions = True
config.publish_output_progress = True
config.verbosity_level = 0
config.use_extra_bad_extensions = False
config.publish_logs = False
config.use_wiki_settings_file = True
config.use_repo_settings_file = True
config.use_global_settings_file = True
config.disable_auto_feedback = False
config.ai_timeout = 120
config.response_language = 'en-US'
config.patch_extension_skip_types = ['.md', '.txt']
config.extra_allowed_extensions = []
config.allow_dynamic_context = True
config.max_extra_lines_before_dynamic_context = 10
config.patch_extra_lines_before = 5
config.patch_extra_lines_after = 1
config.cli_mode = False
config.calculate_context = True
config.disable_checkboxes = False
config.output_relevant_configurations = False
config.large_patch_policy = 'clip'
config.seed = -1
config.temperature = 0.2
config.allow_dynamic_context_ab_testing = False
config.choose_dynamic_context_ab_testing_ratio = 0.5
config.ignore_pr_title = ['^\\[Auto\\]', '^Auto']
config.ignore_pr_target_branches = []
config.ignore_pr_source_branches = []
config.ignore_pr_labels = []
config.allow_only_specific_folders = []
config.ignore_pr_authors = []
config.is_auto_command = False
config.enable_ai_metadata = True
config.present_reasoning = True
config.max_tickets = 10
config.max_tickets_chars = 8000
config.prevent_any_approval = False
config.enable_comment_approval = False
config.enable_auto_approval = False
config.auto_approve_for_low_review_effort = -1
config.auto_approve_for_no_suggestions = False
config.enable_labeler = True
config.labels_mode = 'custom_only'
==================== github_app ====================
github_app.bot_user = 'github-actions[bot]'
github_app.override_deployment_type = True
github_app.handle_pr_actions = ['opened', 'reopened', 'ready_for_review']
github_app.pr_commands = ['/describe --pr_description.final_update_message=false', '/review', '/improve']
github_app.handle_push_trigger = False
github_app.push_commands = ['/describe', '/review']
github_app.ignore_pr_title = []
github_app.ignore_bot_pr = True |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Many Ruby BiDI and DevTools tests are tagged as
exclusive-if-local, which are currently prevented from running on RBE, so there are tests that haven't been running that are failing.As I understand that tag, it means it shouldn't run in parallel with other tests on the same machine. Since I don't think that happens on EngFlow, I think it should be ok to run these tests on RBE. @shs96c let me know what I'm missing with this.
We should also figure out how to make sure that all tests that are skipped on RBE in any of the bindings are being run on GitHub Actions runners.
At the very least this PR will let us make sure that the Ruby tests we have are all passing.
PR Type
enhancement
Description
Modified
.bazelrc.remoteto allow tests taggedexclusive-if-localto run on RBE.Removed
exclusive-if-localfrom thetest_tag_filtersfor remote testing.Changes walkthrough 📝
.bazelrc.remote
Update `.bazelrc.remote` test configurations for RBE.bazelrc.remote
exclusive-if-localfromtest_tag_filtersundertest:remote.