Skip to content

[py] Fix mypy errors in switch_to file and relative locator file #16300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
+4 −3
Open

[py] Fix mypy errors in switch_to file and relative locator file #16300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bda34a7
fixed mypy errors in switch_to file and relative locator file
pallavigitwork Sep 8, 2025
c911b18
stored frame into another var and passed that in exception
pallavigitwork Sep 9, 2025
7288b92
Merge branch 'trunk' into Fix15697-5
pallavigitwork Sep 9, 2025
e1af0c3
Merge branch 'trunk' into Fix15697-5
pallavigitwork Sep 10, 2025
f9f7abd
Merge branch 'trunk' into Fix15697-5
pallavigitwork Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion py/selenium/webdriver/remote/switch_to.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,14 @@ def frame(self, frame_reference: Union[str, int, WebElement]) -> None:
driver.switch_to.frame(driver.find_elements(By.TAG_NAME, "iframe")[0])
"""
if isinstance(frame_reference, str):
frame_name = frame_reference
try:
frame_reference = self._driver.find_element(By.ID, frame_reference)
except NoSuchElementException:
try:
frame_reference = self._driver.find_element(By.NAME, frame_reference)
except NoSuchElementException as exc:
raise NoSuchFrameException(frame_reference) from exc
raise NoSuchFrameException(frame_name) from exc

self._driver.execute(Command.SWITCH_TO_FRAME, {"id": frame_reference})

Expand Down
4 changes: 2 additions & 2 deletions py/selenium/webdriver/support/relative_locator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from typing import NoReturn, Optional, Union, overload

from selenium.common.exceptions import WebDriverException
from selenium.webdriver.common.by import By, ByType
from selenium.webdriver.common.by import ByType
from selenium.webdriver.remote.webelement import WebElement


Expand Down Expand Up @@ -48,7 +48,7 @@ def with_tag_name(tag_name: str) -> "RelativeBy":
warnings.warn("This method is deprecated and may be removed in future versions. Please use `locate_with` instead.")
if not tag_name:
raise WebDriverException("tag_name can not be null")
return RelativeBy({By.CSS_SELECTOR: tag_name})
return RelativeBy({"css selector": tag_name})


def locate_with(by: ByType, using: str) -> "RelativeBy":
Expand Down