-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added csharp alert code #2089
base: trunk
Are you sure you want to change the base?
added csharp alert code #2089
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍(Review updated until commit 79f3f5f)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to 79f3f5f
Previous suggestionsSuggestions up to commit c66b31d
|
This was earlier merged by Harsha, but i didn't see the changes on the website as i was exploring today, so reopened it and retrieved the deleted branch. unable to understand why is this failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pallavigitwork LGTM.
Please help me to understand the exact link where we missed docs (on https://selenium.dev site). |
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
added csharp alert code
Motivation and Context
code was missing
Types of changes
Checklist
PR Type
Enhancement, Documentation
Description
Added a comprehensive C# example for handling alerts in Selenium.
Updated documentation across multiple languages to reference the new C# example.
Replaced outdated C# code snippets with links to the new example file.
Improved consistency in documentation by aligning C# examples with other languages.
Changes walkthrough 📝
AlertsTest.cs
Added C# test class for alert handling
examples/dotnet/SeleniumDocs/Interactions/AlertsTest.cs
AlertsTest
for handling alerts.alerts.en.md
Updated English documentation with new C# example
website_and_docs/content/documentation/webdriver/interactions/alerts.en.md
AlertsTest
class.alerts.ja.md
Updated Japanese documentation with new C# example
website_and_docs/content/documentation/webdriver/interactions/alerts.ja.md
AlertsTest
class.alerts.pt-br.md
Updated Portuguese documentation with new C# example
website_and_docs/content/documentation/webdriver/interactions/alerts.pt-br.md
AlertsTest
class.alerts.zh-cn.md
Updated Chinese documentation with new C# example
website_and_docs/content/documentation/webdriver/interactions/alerts.zh-cn.md
AlertsTest
class.