Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for enabling Safari browser logging in JavaScript #2127

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Add test for enabling Safari browser logging in JavaScript #2127

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d3ffc6
Add Safari-specific JavaScript tests for logging configuration
yvsvarma Jan 13, 2025
58b28bd
Merge branch 'trunk' into add-safari-logging-example-js
yvsvarma Jan 13, 2025
f0dae4e
Merge branch 'trunk' into add-safari-logging-example-js
yvsvarma Jan 16, 2025
e8e22a5
Merge branch 'trunk' into add-safari-logging-example-js
yvsvarma Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions examples/javascript/test/browser/safariSpecificCap.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,23 @@ describe('Should be able to Test Command line arguments', function () {
await driver.get('https://www.selenium.dev/selenium/web/blank.html');
await driver.quit();
});
});

describe('Should be able to enable Safari logging', function () {
this.timeout(15000);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need timeout in here ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And i don't think this is the right example , Can you check again!

(process.platform === 'darwin' ? it : it.skip)('enableLogs', async function () {
const options = new safari.Options()
.setLoggingPrefs({ browser: 'ALL' }); // Enable browser-level logging

let driver = new Builder()
.forBrowser(Browser.SAFARI)
.setSafariOptions(options)
.build();

try {
await driver.get('https://www.selenium.dev/');
} finally {
await driver.quit();
}
});
});
2 changes: 1 addition & 1 deletion website_and_docs/content/documentation/webdriver/browsers/safari.en.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ Property value: `"true"` or `"false"`
{{< gh-codeblock path="examples/ruby/spec/browsers/safari_spec.rb#L20" >}}
{{< /tab >}}
{{< tab header="JavaScript" >}}
{{< badge-code >}}
{{< gh-codeblock path="/examples/javascript/test/browser/safariSpecificCap.spec.js#L22" >}}
{{< /tab >}}
{{< tab header="Kotlin" >}}
{{< badge-code >}}
Expand Down
2 changes: 1 addition & 1 deletion website_and_docs/content/documentation/webdriver/browsers/safari.ja.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ Property value: `"true"` or `"false"`
{{< gh-codeblock path="examples/ruby/spec/browsers/safari_spec.rb#L20" >}}
{{< /tab >}}
{{< tab header="JavaScript" >}}
{{< badge-code >}}
{{< gh-codeblock path="/examples/javascript/test/browser/safariSpecificCap.spec.js#L22" >}}
{{< /tab >}}
{{< tab header="Kotlin" >}}
{{< badge-code >}}
Expand Down
2 changes: 1 addition & 1 deletion website_and_docs/content/documentation/webdriver/browsers/safari.pt-br.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ Property value: `"true"` or `"false"`
{{< gh-codeblock path="examples/ruby/spec/browsers/safari_spec.rb#L20" >}}
{{< /tab >}}
{{< tab header="JavaScript" >}}
{{< badge-code >}}
{{< gh-codeblock path="/examples/javascript/test/browser/safariSpecificCap.spec.js#L22" >}}
{{< /tab >}}
{{< tab header="Kotlin" >}}
{{< badge-code >}}
Expand Down