You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python it is common to indicate unused variables by choosing _ (underscore) as variable name. This pull request replaces some instances of unused variables in lambda expressions to align with Python customs and also other test examples in the repository.
Types of changes
Change to the site (I have double-checked the Netlify deployment, and my changes look good)
Code example added (and I also added the example to all translated languages)
Improved translation
Added new translation (and I also added a notice to each document missing translation)
In Python it is common to indicate unused variables by choosing _
(underscore) as variable name. This commit replaces some instances of
unused variables in lambda expressions to align with Python customs
and also other test examples in the repository.
The lambda expression in test_explicit_options uses a side effect (send_keys) within the wait condition, which is an anti-pattern. Move the send_keys operation after the wait condition.
-wait.until(lambda _ : revealed.send_keys("Displayed") or True)+wait.until(lambda _ : revealed.is_displayed())+revealed.send_keys("Displayed")
Apply this suggestion
Suggestion importance[1-10]: 9
Why: Having side effects (send_keys) in a wait condition is a poor practice that can lead to race conditions and flaky tests. Moving the send_keys operation after waiting for visibility makes the test more reliable and follows better testing patterns.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Description
In Python it is common to indicate unused variables by choosing _ (underscore) as variable name. This pull request replaces some instances of unused variables in lambda expressions to align with Python customs and also other test examples in the repository.
Types of changes
Checklist
PR Type
Enhancement
Description
Replaced unused variables in lambda expressions with
_for Python convention.Improved code readability and consistency with Python customs.
Changes walkthrough 📝
test_waits.py
Update lambda expressions to use `_` for unused variablesexamples/python/tests/waits/test_waits.py
dwith_in lambda expressions to indicate unused variables.test_explicitandtest_explicit_options) forbetter readability.