You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo to show an option for how we might improve things. It overflows the tab, so this isn't what we actually want, but looking for feedback on the concept.
PR Type
Enhancement
Description
Added a collapsible details tag to display full code examples.
Improved user experience by showing snippets with an option for full content.
Enhanced conditional rendering for fragments in code blocks.
Changes walkthrough 📝
Relevant files
Enhancement
gh-codeblock.html
Added collapsible full example display for code snippets
The details tag implementation may need additional CSS styling to ensure consistent appearance across browsers and proper integration with the existing design.
<detailsclass="mt-2"><summary>Show full example</summary><divclass="pt-2">{{ highlight $content $language }}</div></details>
{{ if $hasFragment }}
-<details class="mt-2">+<details class="mt-2" aria-label="Full code example">
<summary>Show full example</summary>
<div class="pt-2">{{ highlight $content $language }}</div>
</details>
{{ end }}
Apply this suggestion
Suggestion importance[1-10]: 7
__
Why: Adding an aria-label to the details element is a good accessibility improvement that helps screen reader users understand the purpose of the collapsible section before interacting with it. This enhances the user experience for people with disabilities.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Demo to show an option for how we might improve things. It overflows the tab, so this isn't what we actually want, but looking for feedback on the concept.
PR Type
Enhancement
Description
Added a collapsible
detailstag to display full code examples.Improved user experience by showing snippets with an option for full content.
Enhanced conditional rendering for fragments in code blocks.
Changes walkthrough 📝
gh-codeblock.html
Added collapsible full example display for code snippetswebsite_and_docs/layouts/shortcodes/gh-codeblock.html
detailstag to display full examples.