Conversation
qbart
requested changes
Nov 26, 2025
Member
qbart
left a comment
qbart
left a comment
There was a problem hiding this comment.
some changes required,
also it would be useful to have some readme or cloud.selleo.com update to explain how to prepare s3 for TF backend
|
|
||
| data "aws_iam_policy_document" "ses_sender" { | ||
| statement { | ||
| actions = ["ses:SendRawEmail"] |
| @@ -0,0 +1,23 @@ | |||
| data "aws_route53_zone" "name" { # TODO adjust name to your project | |||
Member
There was a problem hiding this comment.
in this case i think it is fine to call it "main"
| @@ -0,0 +1,29 @@ | |||
| resource "random_id" "example" { | |||
| @@ -0,0 +1,29 @@ | |||
| resource "random_id" "example" { | |||
Comment on lines
+16
to
+19
| editable_secrets = { | ||
| CORS_ORIGIN = "Edit in AWS Console" | ||
| ENVIRONMENT = "Edit in AWS Console" | ||
| } |
Member
There was a problem hiding this comment.
remove editables everywhere, let people mange via UI only
Comment on lines
+16
to
+20
| editable_secrets = { | ||
| CORS_ORIGIN = "Edit in AWS Console" | ||
| ENVIRONMENT = "Edit in AWS Console" | ||
| } | ||
| } No newline at end of file |
| verify_dkim = true | ||
| dmarc_enabled = true | ||
| spf_enabled = true | ||
| email_addresses = [ |
Member
There was a problem hiding this comment.
production ses, should not have emails as a whitelist anyumore (staging should)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.