Skip to content

ItemKey: Add ItemKey::Description mapping for Vorbis Comments #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Serial-ATA merged 1 commit into from
Jan 7, 2026
+7 −0
Merged

ItemKey: Add ItemKey::Description mapping for Vorbis Comments #587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
ISO 3166-1 code.
- `ItemKey::AcoustId` and `ItemKey::AcoustIdFingerprint` ([issue](https://github.com/Serial-ATA/lofty-rs/issues/455)) ([PR](https://github.com/Serial-ATA/lofty-rs/pull/575))
- These two fields come from [AcoustID], and can appear multiple times in a single tag.
- `ItemKey::Description` mapping for Vorbis Comments ([issue](https://github.com/Serial-ATA/lofty-rs/issues/585)) ([PR](https://github.com/Serial-ATA/lofty-rs/pull/587))
- **Serde**: [Serde] support for `*Type` enums (`FileType`, `TagType`, `PictureType`) ([issue](https://github.com/Serial-ATA/lofty-rs/issues/533)) ([PR](https://github.com/Serial-ATA/lofty-rs/pull/534))
- Support can be enabled with the new `serde` feature (not enabled by default)
- **Probe**: `Probe::read_bound()` ([PR](https://github.com/Serial-ATA/lofty-rs/pull/557))
Expand Down
6 changes: 6 additions & 0 deletions lofty/src/tag/item.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,12 @@ gen_map!(
"COPYRIGHT" => CopyrightMessage,
"LICENSE" => License,
"COMMENT" => Comment,
// This field comes from the spec: <https://xiph.org/vorbis/doc/v-comment.html#fieldnames>
//
// But doesn't seem to actually be used anywhere? AFAICT, it was meant to serve the same purpose as
// "COMMENT". I haven't found any cases of taggers converting this field to "COMMENT" though, so
// it's probably safest to keep the two distinct.
"DESCRIPTION" => Description,
"LANGUAGE" => Language,
"SCRIPT" => Script,
"LYRICS" => Lyrics,
Expand Down