Product API Enhancements, Order API Bugfix #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not possible via CustomersController.CreateCustomer due to validation requirements on the CustomerDto).
Merge latest from upstream
Merge latest from upstream
Merge latest from upstream
This commit fixes an issue where creating an order would double the line item quantity for items that already exist as ShoppingCartItem records for a given customer.
pkmccaffrey
changed the title
|
This looks very useful. Any timelines for merging this in? |
…y & discount doubling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two parameters to the product API calls:
There is an extra commit in this PR that relates to creating guest customers. This was a mistake, and should not have made it into this branch. That code was been removed in the last commit.
Additionally, this PR now also includes a bug for for #182 .