Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces deep merge with shallow key sets on alreadyIncluded #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgebeily
Copy link

I've encountered some performance issues using lodash's _set and _merge objects. I clocked in over 10 seconds for deserialization of a large, nested JSONAPI object. This isn't a fault of the library, just the nature of deep merges.

I've replaced the deep merge with a top level key set of a stringified path and brought down deserialization time on my case to be negligible.

Feedback is appreciated. Thanks in advance!

@mgebeily
Copy link
Author

@SeyZ Let me know if you have any thoughts or if you'd want a test for performance on here with one of the edge cases I was encountering before. Thanks!

@mgebeily
Copy link
Author

@SeyZ Wanted to circle back one last time and see if there's any interest in merging this. My team is currently running off of a fork of this repo which we'd like to make a temporary solution if possible!

@Kuhreez
Copy link

Kuhreez commented May 21, 2021

@SeyZ Is there any interest in merging this? Seems like a good change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants