Replaces deep merge with shallow key sets on alreadyIncluded #212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered some performance issues using lodash's
_set
and_merge
objects. I clocked in over 10 seconds for deserialization of a large, nested JSONAPI object. This isn't a fault of the library, just the nature of deep merges.I've replaced the deep merge with a top level key set of a stringified path and brought down deserialization time on my case to be negligible.
Feedback is appreciated. Thanks in advance!