Fix(Hardware Support): Avoid using name as match for Ally/AllyX devices. #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Combine Xbox and standard Ally device configs - Simplify evdev matches to not use name Due to frequent changes to drivers upstream and OOT, there has been a lot of volatility in the configuration for the Ally and Ally X devices. To avoid further meddling by outside actors, drop any hid-asus, his-asus-ally, or asus-ally-hid name attributes and bulk match all devices with the VID/PID pairs. While at it, reduce the number of device configs.
LukeShortCloud
approved these changes
Nov 25, 2025
Contributor
LukeShortCloud
left a comment
LukeShortCloud
left a comment
There was a problem hiding this comment.
I tested and confirmed this is working on an original Ally and the Xbox Ally X. I removed the 50-rog_xbox_ally* profiles and updated the 50_rog_ally* profiles.
# Ally 1
$ inputplumber device 0 info
╭────┬───────────────┬──────────────┬──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ Composite Device │
├────┼───────────────┼──────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ Id │ Name │ Profile Name │ Source Devices │
├────┼───────────────┼──────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ 0 │ ASUS ROG Ally │ default │ ["/dev/hidraw3", "/dev/input/event3", "/dev/input/event4", "/dev/input/event5", "/dev/input/event7", "/dev/iio:device0", ""] │
╰────┴───────────────┴──────────────┴──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
# Xbox Ally X
$ inputplumber device 0 info
╭────┬─────────────────┬──────────────┬─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ Composite Device │
├────┼─────────────────┼──────────────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ Id │ Name │ Profile Name │ Source Devices │
├────┼─────────────────┼──────────────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ 0 │ ASUS ROG Ally X │ default │ ["/dev/hidraw2", "/dev/hidraw3", "/dev/input/event2", "/dev/input/event3", "/dev/input/event5", "/dev/iio:device0", ""] │
╰────┴─────────────────┴──────────────┴─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
ShadowApex
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to frequent changes to drivers upstream and OOT, there has been a lot of volatility in the configuration for the Ally and Ally X devices. To avoid further meddling by outside actors, drop any hid-asus, his-asus-ally, or asus-ally-hid name attributes and bulk match all devices with the VID/PID pairs.
While at it, reduce the number of device configs.