- Adding support for use of StringRes, ColorRes

Shashank02051997 · Sep 17, 2020 · a6238d8 · a6238d8
1 parent ad15992
commit a6238d8
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 13 deletions.
diff --git a/README.md b/README.md
@@ -31,7 +31,7 @@ Add this to your module's `build.gradle` file (make sure the version matches the
 ```gradle
 dependencies {
 	...
-	implementation 'com.github.Shashank02051997:FancyGifDialog-Android:1.2'
+	implementation 'com.github.Shashank02051997:FancyGifDialog-Android:1.3'
 }
 ```
 ## Fancy Gif Dialog
@@ -40,12 +40,12 @@ Dialog with two buttons:
 
 ``` java
 new FancyGifDialog.Builder(this)
-                .setTitle("Granny eating chocolate dialog box")
-                .setMessage("This is a granny eating chocolate dialog box. This library is used to help you easily create fancy gify dialog.")
-                .setNegativeBtnText("Cancel")
-                .setPositiveBtnBackground("#FF4081")
-                .setPositiveBtnText("Ok")
-                .setNegativeBtnBackground("#FFA9A7A8")
+                .setTitle("Granny eating chocolate dialog box") // You can also send title like R.string.from_resources
+                .setMessage("This is a granny eating chocolate dialog box. This library is used to help you easily create fancy gify dialog.") // or pass like R.string.description_from_resources
+                .setNegativeBtnText("Cancel") // or pass it like android.R.string.cancel
+                .setPositiveBtnBackground("#FF4081") // or pass it like R.color.positiveButton
+                .setPositiveBtnText("Ok") // or pass it like android.R.string.ok
+                .setNegativeBtnBackground("#FFA9A7A8") // or pass it like R.color.negativeButton
                 .setGifResource(R.drawable.gif1)   //Pass your Gif here
                 .isCancellable(true)
                 .OnPositiveClicked(new FancyGifDialogListener() {

diff --git a/fancygifdialoglib/src/main/java/com/shashank/sony/fancygifdialoglib/FancyGifDialog.java b/fancygifdialoglib/src/main/java/com/shashank/sony/fancygifdialoglib/FancyGifDialog.java
@@ -8,7 +8,6 @@
 import android.view.View;
 import android.view.Window;
 import android.widget.Button;
-import android.widget.ImageView;
 import android.widget.TextView;
 
 import androidx.annotation.ColorRes;
@@ -139,7 +138,6 @@ public Builder setGifResource(int gifImageResource) {
 
         public FancyGifDialog build() {
             TextView message1, title1;
-            ImageView iconImg;
             Button nBtn, pBtn;
             GifImageView gifImageView;
 

diff --git a/fancygifdialoglib/src/main/res/layout/fancygifdialog.xml b/fancygifdialoglib/src/main/res/layout/fancygifdialog.xml
@@ -53,10 +53,10 @@
                         android:gravity="center"
                         android:paddingLeft="16dp"
                         android:paddingRight="16dp"
-                        tools:text="Granny eating chocolate dialog box"
                         android:textAlignment="center"
                         android:textColor="#000000"
-                        android:textSize="16dp" />
+                        android:textSize="16dp"
+                        tools:text="Granny eating chocolate dialog box" />
 
                     <TextView
                         android:id="@+id/message"
@@ -67,9 +67,9 @@
                         android:gravity="center"
                         android:paddingLeft="16dp"
                         android:paddingRight="16dp"
-                        tools:text="This is a granny eating chocolate dialog box. This library is used to help you easily create fancy gify dialog."
                         android:textAlignment="center"
-                        android:textSize="14dp" />
+                        android:textSize="14dp"
+                        tools:text="This is a granny eating chocolate dialog box. This library is used to help you easily create fancy gify dialog." />
 
                     <LinearLayout
                         android:layout_width="match_parent"