Fix keylistener handling, resolve race condition, and correct delete chat functionality #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the following issues:
gpt3-tokenizerwithjs-tiktokenfor Enhanced Tokenization Performance #112.Background
svelte-command-palettelibrary stops the propagation of arrow keys by callingpreventDefault. This workaround adjusts the keylistener logic to allow arrow key navigation within the textarea. More details can be found in the issue posted here: [bug] keybing triggered unexpectedly even when the palette is not visible rohitpotato/svelte-command-palette#16.gpt3-tokenizerwithjs-tiktokenfor Enhanced Tokenization Performance #112. It was caused by a functiongetProviderForModelreturningundefinedbefore checking if the model isundefined. The function now ensures proper checks to avoid this issue.Changes
Related PRs
gpt3-tokenizerwithjs-tiktokenfor Enhanced Tokenization Performance #112Issue References
Testing