feat!(sim): Change naming convention of simulation output #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olantwin
force-pushed
the
naming
branch
2 times, most recently
from
2e12699 to
cb86b7a
Compare
Contributor
Author
|
Probably there should be an option to have a predictable filename as well for e.g. the CI. |
webbjm
approved these changes
Sep 19, 2025
olantwin
force-pushed
the
naming
branch
2 times, most recently
from
be67665 to
8d6463c
Compare
Changes simulation output file naming from descriptive names
(ship.conical.Pythia8-TGeant4.root) to UUID-based names
(sim_{uuid}.root, geo_{uuid}.root, params_{uuid}.root) to avoid
file name collisions.
Adds optional --tag parameter to allow specifying custom identifier
instead of auto-generated UUID when deterministic names are needed.
BREAKING CHANGE: Simulation output files now use new naming convention
{sim,geo,params}_{uuid}.root instead of ship.{tag}.root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #811