Repository navigation
Fix setup retries, unload cleanup and reauth form errors - #321
Merged
Merged
Conversation
Sholofly
commented
Oct 30, 2026
Sholofly
commented
Owner
- Disconnect the API when the config entry unloads or fails to set up. Reloading used to leave the old MQTT connection running.
- Raise ConfigEntryNotReady for a connection error during setup so Home Assistant retries, and drop the matching on error message text. A real authentication failure still starts reauthentication.
- Catch the locked account error before the unauthorized error it derives from, so it can be reached.
- Show invalid_auth, account_locked, cannot_connect and unknown on the reauth form. The step raised these errors without catching them, so a wrong password ended in an unhandled exception.
- Add tests for setup, unload, reload and the reauth flow.
- Disconnect the API when the config entry unloads or fails to set up. Reloading used to leave the old MQTT connection running. - Raise ConfigEntryNotReady for a connection error during setup so Home Assistant retries, and drop the matching on error message text. A real authentication failure still starts reauthentication. - Catch the locked account error before the unauthorized error it derives from, so it can be reached. - Show invalid_auth, account_locked, cannot_connect and unknown on the reauth form. The step raised these errors without catching them, so a wrong password ended in an unhandled exception. - Add tests for setup, unload, reload and the reauth flow. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.