Repository navigation
Narrow the broad exception handling - #324
Merged
Merged
Conversation
Sholofly
commented
Oct 30, 2026
Sholofly
commented
Owner
- The best-effort fetches of replay channels, the EPG and event details caught every exception, which also hid programming errors. Catch the library errors and unexpected payload shapes instead.
- Adding an SSDP-discovered device only aborts for library errors.
- Stop validate_config from turning every unexpected error into "cannot connect". It now falls through to the caller, which shows the unknown error and logs the traceback.
- Add tests for the media player fetches and for the config flow errors.
- The best-effort fetches of replay channels, the EPG and event details caught every exception, which also hid programming errors. Catch the library errors and unexpected payload shapes instead. - Adding an SSDP-discovered device only aborts for library errors. - Stop validate_config from turning every unexpected error into "cannot connect". It now falls through to the caller, which shows the unknown error and logs the traceback. - Add tests for the media player fetches and for the config flow errors. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.