fix: correct the clientX and clientY of touch sensor events#423
fix: correct the clientX and clientY of touch sensor events#423zjffun wants to merge 1 commit intoShopify:mainfrom
Conversation
|
It was written this way from the beginning. Is there any compatibility reason to use page instead of client? @tsov |
cf1a703 to
6df492f
Compare
|
Hi @zjffun , @tsov . In my opinion, And based on zjffun PR, we can see that change from If we don't have any compatibility reason to use |
|
Thanks for your review. It seems that A very old bug of
seems fixed |
|
It seems that using Both of them have the little bug that should fix by webkit when dragging and scrolling. |
This will bring a breaking change! Because it will change the clientX and clientY of each SensorEvent triggered by touchs.
This PR fixes the clientX and clientY of the touch sensor events.
This PR closes the following issues... (if applicable)
No
Does this PR require the Docs to be updated?
No
Does this PR require new tests?
Yes
This branch been tested on... (click all that apply / add new items)
Browsers: