Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add supported_buyer_context examples to payment app extensions #127

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add supported_buyer_context examples to payment app extensions #127

wants to merge 2 commits into from

Conversation

punkstar
Copy link
Member

@punkstar punkstar commented Jul 17, 2024 •
edited
Loading

Background

Adds supported_buyer_contexts example values into the example templates for payment app extensions.

Closes https://github.com/Shopify/payments-platform/issues/5946.

Solution

As they're optional, commented them out.

Checklist

  • I have 🎩'd these changes
  • I have squashed my commits into chunks of work with meaningful commit messages

@punkstar punkstar marked this pull request as ready for review July 17, 2024 14:15
lacoursieresimon
lacoursieresimon approved these changes Jul 17, 2024
View reviewed changes
Copy link

@lacoursieresimon lacoursieresimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just change the configs for a valid one, but good otherwise.

payments-app-extension-credit-card/shopify.extension.toml.liquid Outdated Show resolved Hide resolved
@punkstar punkstar force-pushed the punkstar/payment-apps-supported-buyer-contexts branch from 7bb808e to 6a50439 Compare July 18, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romidane romidane romidane approved these changes

@lacoursieresimon lacoursieresimon lacoursieresimon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@punkstar @romidane @lacoursieresimon