Update customer account template to 1 target #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaokx
force-pushed
the
customer-account-1target-lh
branch
2 times, most recently
from
9bf212b
to
9bf5f83
Compare
lihaokx
force-pushed
the
customer-account-1target-lh
branch
from
9bf5f83
to
20aecca
Compare
lihaokx
force-pushed
the
customer-account-1target-lh
branch
from
20aecca
to
1ab57df
Compare
lihaokx
requested review from
robin-drexler,
brianshen1990,
vividviolet and
MitchLillie
lihaokx
force-pushed
the
customer-account-1target-lh
branch
from
1ab57df
to
e90c720
Compare
brianshen1990
approved these changes
Sep 20, 2024
robin-drexler
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Resolves: https://github.com/Shopify/core-issues/issues/74361
Change the number of targets in customer account template from 2 to 1. This is the same as checkout template.
Tophat
You could see tophat in this video: https://github.com/Shopify/core-issues/issues/74361#issue-2435979752
Checklist