Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shopify.extension.toml.liquid #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

drose-shopify
Copy link

@drose-shopify drose-shopify commented Oct 12, 2023

Shopify/cli#2938

Includes optional changes to the toml to include the new [input.metafield_identifiers] object.

Background

We've added a new field that a tax_calculation extension can set called input.metafield_identifiers which is an object containing a namespace/key pair. The field is intended to be a metafield reference where the partner will store which metafields per merchant they want Shopify to query the value for come tax calculation time to passed back to the app.

Solution

Shopify/cli#2938
https://github.com/Shopify/shopify/pull/456448 --> how we intend to use it.

Checklist

  • I have 🎩'd these changes
  • I have squashed my commits into chunks of work with meaningful commit messages

Shopify/cli#2938

Includes optional changes to the toml to include the new `[input.metafield_identifiers]` object.
@drose-shopify drose-shopify requested a review from a team as a code owner October 12, 2023 15:42
@drose-shopify drose-shopify self-assigned this Oct 12, 2023
Copy link

@sunithapatel sunithapatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants