Fix onStartReached detection #1932
Open
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I signed the cla |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When scrolling up with
onStartReacheduseBoundDetectiondoes not properly check scroll position while scrolling up. This resulted inonStartReachedonly firing when reaching the very top of the list and also firing while near top of the list and scrolling down. It was missingfirstItemOffsetin the calculation and missingpendingStartReached.current = falseon data changes.Fixes (issue #) #1872
Likely fixes
#1915
#1844
#1864
Reviewers’ hat-rack 🎩
Screenshots or videos (if needed)