Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate well known types for to_proto #151

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Regenerate well known types for to_proto #151

merged 1 commit into from
Aug 23, 2024

Conversation

rwstauner
Copy link
Contributor

from #149

@rwstauner rwstauner requested a review from paracycle August 23, 2024 19:16
paracycle
paracycle approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@paracycle paracycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff LGTM, but I wonder if we should not be committing these files to the repo, but making their generation a part of building the gem, in the first place?

@rwstauner
Copy link
Contributor Author

That's a good question, maybe we should open an issue for discussion.

@paracycle
Copy link
Member

That's a good question, maybe we should open an issue for discussion.

Sure, do you mind doing that?

@rwstauner rwstauner merged commit 81cbb65 into Shopify:main Aug 23, 2024
4 checks passed
@rwstauner rwstauner deleted the to-proto-regen branch August 23, 2024 20:05
This was referenced Aug 23, 2024
Merged
Open
@rwstauner
Copy link
Contributor Author

created #153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paracycle paracycle paracycle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwstauner @paracycle