Avoiding session file names that are too long

[alexanderadam]

refs #267

PS: I'm looking for a new adventure in case anybody is looking to hire or work with a Ruby/Rails/Crystal dev
PPS: would you be so kind and add the hacktoberfest-accepted label to this issue in case you find that PR helpful? 🥺

[nfgrep]

Either make the helper generic enough to apply to any fpath or move the logic into file_state_repository and have it be specific to session fpaths

[juniper-shopify]

Thanks for sending this! I'd recommend the latter suggestion from @nfgrep (move it into the file_state_repository).

I think general filename safety is important, but there are enough different ways that a file name might be generated that I don't want to settle on one global answer to soon. Until we find ourselves implementing several similar instances of a safe filename utility for a different specific purposes, it's a lot easier to keep things like this purpose-specific

[alexanderadam]

I moved the logic into lib/roast/workflow/file_state_repository.rb now and the file suffix is now an optional argument defaulting to .json. 🙂

[nfgrep]

Appreciate the move into file_state_repository.rb ❤️ Just a few straggler questions to answer, with those addressed we should be good to merge :)